Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Consider changing "Search Engine" setting to "Search" #5371

Closed
sblatz opened this issue Sep 16, 2019 · 6 comments
Closed

[Bug] Consider changing "Search Engine" setting to "Search" #5371

sblatz opened this issue Sep 16, 2019 · 6 comments
Assignees
@sblatz
Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Milestone
v2.1

Comments

@sblatz
Copy link
Contributor

sblatz commented Sep 16, 2019 •
edited by data-sync-user
Loading

Currently our "Search engine" setting (under the "Basics" heading) links to a page that controls more than just the Search engines. We should get new copy for this string and update it.

image

image

@jpfaller for string on this :)

┆Issue is synchronized with this Jira Task
@sblatz sblatz added 🐞 bug Crashes, Something isn't working, .. needs:strings Needs strings labels Sep 16, 2019
@ekager ekager mentioned this issue Sep 17, 2019
Closed
@jpfaller
Copy link

Let's call it

"Search"

and then remove the subtext where we show the search engine they've picked (In this screenshot, Google)

@jpfaller jpfaller removed the needs:strings Needs strings label Sep 17, 2019
@sblatz sblatz added approved:strings E1 Estimation Point: trivial, less than half day S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist P2 Upcoming release labels Sep 17, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Sep 17, 2019

I'm pulling this in since it's a very easy fix and was related to a feature I did in 2.0 (new issue introduced)

@sblatz sblatz self-assigned this Sep 17, 2019
@sblatz sblatz added this to To be Triaged in Fenix Sprint Kanban via automation Sep 17, 2019
@sblatz sblatz added this to the v2.1 milestone Sep 17, 2019
@sblatz sblatz moved this from To be Triaged to In Progress in Fenix Sprint Kanban Sep 17, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Sep 17, 2019
@sblatz
For mozilla-mobile#5371: Updates search engine settings string
0ca1084
@sblatz
Copy link
Contributor Author

sblatz commented Sep 17, 2019

@jpfaller When I change it to just say "search" it's not clear that you're selecting a default engine:

image

Because of that I've updated it to look like this:
image

sblatz added a commit to sblatz/fenix that referenced this issue Sep 17, 2019
@sblatz
For mozilla-mobile#5371: Updates search engine settings string
8412458
@sblatz sblatz moved this from In Progress to In Review in Fenix Sprint Kanban Sep 17, 2019
@jpfaller
Copy link

Can it say "Default search engine" ? If not I think this is OK

sblatz added a commit to sblatz/fenix that referenced this issue Sep 18, 2019
@sblatz
For mozilla-mobile#5371: Updates search engine settings string
97a7f5b
sblatz added a commit to sblatz/fenix that referenced this issue Sep 18, 2019
@sblatz
For mozilla-mobile#5371: Updates search engine settings string
d230495
sblatz added a commit that referenced this issue Sep 18, 2019
@sblatz
For #5371: Updates search engine settings string (#5393)
50cd292
@sblatz sblatz added the eng:qa:needed QA Needed label Sep 18, 2019
@sblatz sblatz moved this from In Review to Ready for QA in Fenix Sprint Kanban Sep 18, 2019
@nahuhh
Copy link

nahuhh commented Sep 20, 2019

Looks good

@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Sep 20, 2019
@project-bot project-bot bot moved this from Ready for QA to In Progress in Fenix Sprint Kanban Sep 20, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 20, 2019

Hi, verified as fixed on Nightly Build #12621819 from 19/9 using the following devices:
• Google Pixel 3a (Android 9)
• Samsung Galaxy Note 9 (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

►Pics
rsz_screenshot_20190920-124926

rsz_screenshot_20190920-124933

@AndiAJ AndiAJ closed this as completed Sep 20, 2019
Fenix Sprint Kanban automation moved this from In Progress to Done Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
🐞 bug Crashes, Something isn't working, .. E1 Estimation Point: trivial, less than half day eng:qa:verified QA Verified P2 Upcoming release S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
4 participants
@sblatz @nahuhh @jpfaller @AndiAJ