Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5371: Updates search engine settings string #5393

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Sep 17, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)

  • Tests: This PR includes thorough tests or an explanation of why it does not
    No tests needed, just a small pref/string change

  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not

image

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested review from a team as code owners September 17, 2019 20:42
@NotWoods NotWoods added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Sep 17, 2019
@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #5393 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5393      +/-   ##
============================================
+ Coverage     12.57%   12.57%   +<.01%     
  Complexity      260      260              
============================================
  Files           248      248              
  Lines         10289    10288       -1     
  Branches       1515     1517       +2     
============================================
  Hits           1294     1294              
+ Misses         8908     8907       -1     
  Partials         87       87
Impacted Files Coverage Δ Complexity Δ
...ava/org/mozilla/fenix/settings/SettingsFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...org/mozilla/fenix/settings/SearchEngineFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e4f2d...d230495. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants