Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

UX componentization of CFR (contextual notifications) #5499

Closed
5 tasks
sblatz opened this issue Sep 23, 2019 · 9 comments
Closed
5 tasks

UX componentization of CFR (contextual notifications) #5499

sblatz opened this issue Sep 23, 2019 · 9 comments
Labels
E5 Estimation Point: about 5 days eng:health Improve code health eng:ready Ready for engineering P2 Upcoming release style guide Issues related to the UX style guide wontfix

Comments

@sblatz
Copy link
Contributor

sblatz commented Sep 23, 2019

Child of #4841

Currently we have no standardization for these notifications, and we just reuse a template. Let's build what we need now (and if requirements change, we can update).

Acceptance Criteria

  • There is a a context hint class engineers can utilize for contextual hints
  • There is a living (and public) style guide that both engineers & UX can point to when discussing designs
  • Every contextual hint in the app will adhere to a common pattern so we have consistency

Stretch goal: This style lives in a library we can import separately from Fenix (like in AC)

  • Let's get as far as we can towards getting "scaffolding" for creating future componentized UI elements
  • The contextual "just in time" notifications are componentized in AC (they have a generic styling with certain colors/properties that can be overridden if absolutely necessary)

General Process

  • Engineer implements the style
  • UX & Engineering meet to do “final approval” of the component
    1. Walk through all affected screens
    2. Chat about remaining questions
  • UX & Engineering place component in the library

Terminology for component:
CFR

Example of what we're talking about
Screen Shot 2019-10-30 at 10 52 30 AM

┆Issue is synchronized with this Jira Task

@sblatz sblatz added the feature request 🌟 New functionality and improvements label Sep 23, 2019
@sblatz sblatz added needs:group-triage eng:health Improve code health labels Oct 1, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Oct 1, 2019

Discussed in group triage, these types of tickets will live in the eng health backlog.

@sblatz sblatz removed feature request 🌟 New functionality and improvements needs:group-triage labels Oct 1, 2019
@sblatz sblatz added this to To be Triaged in Fenix Sprint Kanban via automation Oct 1, 2019
@liuche liuche moved this from To be Triaged to Prioritized Eng Backlog in Fenix Sprint Kanban Oct 1, 2019
@sblatz sblatz added the P2 Upcoming release label Oct 1, 2019
@sblatz sblatz changed the title UX componentization of "Just in Time" notifications UX componentization of contextual notifications Oct 25, 2019
@liuche liuche added the E5 Estimation Point: about 5 days label Oct 25, 2019
@liuche liuche moved this from Prioritized Eng Backlog to Sprint Backlog in Fenix Sprint Kanban Oct 25, 2019
@severinrudie
Copy link
Contributor

@lime124 if we have questions about what UX wants from this component, which designer should we reach out to?

@lime124 lime124 changed the title UX componentization of contextual notifications UX componentization of CFR (contextual notifications) Oct 30, 2019
@brampitoyo
Copy link

@baron-severin You can reach out to @AmyYLee, who’s now been assigned to this issue.

@liuche liuche moved this from Sprint Backlog to Prioritized Eng Backlog in Fenix Sprint Kanban Nov 8, 2019
NotWoods added a commit to NotWoods/fenix that referenced this issue Jul 20, 2020
@apbitner
Copy link

Visual design specs for CFR's can be found in Abstract, showing how a CFR may look in different contexts and variations: https://share.goabstract.com/7cae7a97-58d9-4a3f-9098-3c242e0eef7a

We also have interaction design specs and guidelines that can be found in our UI Components deck: https://docs.google.com/presentation/d/1b7mAuUwH5e-rLOKd8dJg2lD08KSl-3hiVEesm2y1t1k/edit#slide=id.g72ea51acf8_4_89

@apbitner apbitner added the eng:ready Ready for engineering label Sep 15, 2020
@liuche
Copy link
Contributor

liuche commented Oct 8, 2020

@apbitner are we still using the purple popups vs the banners (like in #14920)? If so, we could pick this up.

@apbitner
Copy link

apbitner commented Oct 8, 2020

@liuche Yes to my knowledge the purple popups aren't going anywhere, the banner was just a new type of CFR that was introduced.

@liuche liuche added this to Triage in Design Consistency Oct 8, 2020
@liuche liuche moved this from Triage to Backlog in Design Consistency Oct 8, 2020
@liuche
Copy link
Contributor

liuche commented Oct 8, 2020

Based on #9888, the work for this issue would be

Acceptance Criteria (how do I know when I’m done?)

  • There is a a context hint class engineers can utilize for contextual hints
  • There is a living (and public) style guide that both engineers & UX can point to when discussing designs
  • Every contextual hint in the app will adhere to a common pattern so we have consistency

Stretch goal: This style lives in a library we can import separately from Fenix (like in AC)

General Process

  • Engineer implements the style
  • UX & Engineering meet to do “final approval” of the component
    1. Walk through all affected screens
    2. Chat about remaining questions
  • UX & Engineering place component in the library

@liuche
Copy link
Contributor

liuche commented Oct 8, 2020

I've also added this to the Design Consistency board where the rest of the style guide / ux componentization tickets live.

@stale
Copy link

stale bot commented Apr 6, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:health Improve code health eng:ready Ready for engineering P2 Upcoming release style guide Issues related to the UX style guide wontfix
Projects
No open projects
Development

No branches or pull requests

7 participants