Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5499 - Unify CFR drawables and dimens #12749

Merged
merged 1 commit into from Jul 20, 2020

Conversation

NotWoods
Copy link
Contributor

Using tint lets us remove duplicate drawables.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@NotWoods NotWoods added the eng:health Improve code health label Jul 20, 2020
Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 🔲 🔴

@NotWoods NotWoods closed this Jul 20, 2020
@NotWoods NotWoods reopened this Jul 20, 2020
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@fcb84d9). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #12749   +/-   ##
=========================================
  Coverage          ?   26.99%           
  Complexity        ?      954           
=========================================
  Files             ?      399           
  Lines             ?    15904           
  Branches          ?     2037           
=========================================
  Hits              ?     4294           
  Misses            ?    11281           
  Partials          ?      329           
Impacted Files Coverage Δ Complexity Δ
...ix/trackingprotection/TrackingProtectionOverlay.kt 78.43% <100.00%> (ø) 10.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb84d9...7d2a1f1. Read the comment docs.

@NotWoods NotWoods merged commit f73411b into mozilla-mobile:master Jul 20, 2020
@NotWoods NotWoods deleted the 5499_cfr-triangle-drawable branch July 20, 2020 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:health Improve code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants