Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Cannot switch to normal tabs if Fenix is opened in private mode #5681

Closed
Lululalu opened this issue Sep 30, 2019 · 4 comments
Closed

[Bug] Cannot switch to normal tabs if Fenix is opened in private mode #5681

Lululalu opened this issue Sep 30, 2019 · 4 comments
Assignees
@sblatz
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Release Blocker Blocks a Release
Milestone
v2.1

Comments

@Lululalu
Copy link

Lululalu commented Sep 30, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

Long press the Firefox Icon
Touch "new private tab"
Touch the tabs icon
Close the currently open tab
Touch the mask button to leave the private mode

Expected behavior

A normal browsing is started

Actual behavior

A white page is exhibited

Device information

  • Android device: Galaxy A5 2017 Android 8.0
  • Fenix version: 190928 nightly

┆Issue is synchronized with this Jira Task
@Lululalu Lululalu added the 🐞 bug Crashes, Something isn't working, .. label Sep 30, 2019
@sblatz
Copy link
Contributor

sblatz commented Sep 30, 2019

I can reproduce this and I believe it should be a v2.1 release blocker.

@sblatz sblatz self-assigned this Sep 30, 2019
@sblatz sblatz added the Release Blocker Blocks a Release label Sep 30, 2019
@sblatz sblatz added this to the v2.1 milestone Sep 30, 2019
@sblatz
Copy link
Contributor

sblatz commented Sep 30, 2019

It looks like what's happening here is we're opening directly to BrowserFragment when the user stops using private mode. When there's no normal session it has a "blank white screen" but if the user has an open normal tab, it just opens that.

demo

sblatz added a commit to sblatz/fenix that referenced this issue Sep 30, 2019
@sblatz
For mozilla-mobile#5681: Sets OPEN_TO_BROWSER false when using new ta…
b0075be 
…b shortcut
ekager pushed a commit that referenced this issue Sep 30, 2019
@sblatz @ekager
For #5681: Sets OPEN_TO_BROWSER false when using new tab shortcut
69c42b6
@Lululalu Lululalu changed the title [Bug] Cannot switch to normal tabs if Fenix in opened in private mode [Bug] Cannot switch to normal tabs if Fenix is opened in private mode Oct 1, 2019
@sv-ohorvath
Copy link
Contributor

Verified this is fixed on Nightly 10/1. Will check on the RC build as well.

@sblatz sblatz closed this as completed Oct 1, 2019
@sblatz sblatz added the eng:qa:verified QA Verified label Oct 1, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Oct 1, 2019
@sblatz
For mozilla-mobile#5681: Sets OPEN_TO_BROWSER false when using new ta…
0bfdd44 
…b shortcut
sblatz added a commit that referenced this issue Oct 1, 2019
@sblatz
For #5681: Sets OPEN_TO_BROWSER false when using new tab shortcut (#5707
ac2bc18 
)
@sv-ohorvath
Copy link
Contributor

Verified as fixed on 2.1.0-rc3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Release Blocker Blocks a Release
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
3 participants
@sv-ohorvath @sblatz @Lululalu