Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update "launch links in private tab" functionality #5742

Closed
sblatz opened this issue Oct 2, 2019 · 7 comments
Closed

Update "launch links in private tab" functionality #5742

sblatz opened this issue Oct 2, 2019 · 7 comments
Assignees
@sblatz
Labels
E8 Estimation Point: about 8 days eng:qa:verified QA Verified Feature:PrivateBrowsing
Milestone
v2.2

Comments

@sblatz
Copy link
Contributor

sblatz commented Oct 2, 2019 •
edited by data-sync-user
Loading

After some more investigation and discussions with @AmyYLee we're deciding to move forward with the original UX found in #514

We need to bring the activity-alias back and update the default browser pref:

image

┆Issue is synchronized with this Jira Task
@sblatz sblatz added Feature:PrivateBrowsing E5 Estimation Point: about 5 days labels Oct 2, 2019
@sblatz sblatz added this to To be Triaged in Fenix Sprint Kanban via automation Oct 2, 2019
@sblatz sblatz moved this from To be Triaged to In Progress in Fenix Sprint Kanban Oct 2, 2019
@sblatz sblatz self-assigned this Oct 2, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Oct 2, 2019
@sblatz
For mozilla-mobile#5742: Adds strings
cc761f5
sblatz added a commit to sblatz/fenix that referenced this issue Oct 2, 2019
@sblatz
For mozilla-mobile#5742: Adds strings
4defe78
@sblatz sblatz added E8 Estimation Point: about 8 days and removed E5 Estimation Point: about 5 days labels Oct 2, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Oct 3, 2019
@sblatz
For mozilla-mobile#5742: Adds strings
5fb0c23
sblatz added a commit to sblatz/fenix that referenced this issue Oct 3, 2019
@sblatz
For mozilla-mobile#5742: Adds strings
8941801
sblatz added a commit to sblatz/fenix that referenced this issue Oct 3, 2019
@sblatz
For mozilla-mobile#512, mozilla-mobile#5742: Updates "launch links in…
2795a32 
… private tab" functionality
sblatz added a commit to sblatz/fenix that referenced this issue Oct 3, 2019
@sblatz
For mozilla-mobile#514 & mozilla-mobile#5742: Updates "launch links i…
b1d65f3 
…n private tab" functionality
sblatz added a commit that referenced this issue Oct 3, 2019
@sblatz
For #5742: Adds strings (#5743)
097d7c2
sblatz added a commit to sblatz/fenix that referenced this issue Oct 3, 2019
@sblatz
For mozilla-mobile#514 & mozilla-mobile#5742: Updates "launch links i…
ae9e2ec 
…n private tab" functionality
@sblatz sblatz moved this from In Progress to In Dev Review in Fenix Sprint Kanban Oct 3, 2019
sblatz added a commit that referenced this issue Oct 3, 2019
@sblatz
For #514 & #5742: Updates "launch links in private tab" functionality (
371e2ac 
#5721)

* For #514 & #5742: Updates "launch links in private tab" functionality

* Fixes comments
@sblatz sblatz added the eng:qa:needed QA Needed label Oct 3, 2019
@sblatz sblatz moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban Oct 3, 2019
@sblatz sblatz added this to the v2.2 milestone Oct 3, 2019
@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Oct 4, 2019 •
edited
Loading

@sblatz I think this has caused #5784 since the Default browser is hidden on Android 5 & 6.

@sv-ohorvath sv-ohorvath removed the eng:qa:needed QA Needed label Oct 4, 2019
@project-bot project-bot bot moved this from Ready for QA to In Progress in Fenix Sprint Kanban Oct 4, 2019
@sv-ohorvath
Copy link
Contributor

Found 2 new issues on the latest Nightly 10/4. I've set them as blockers to this issue and I'm removing the "qa needed" label until they are fixed.

This was referenced Oct 4, 2019
Closed
Closed
@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Oct 7, 2019 •
edited
Loading

@sblatz @vesta0 The crash is now fixed(on master), but Android 5&6 users won't be able to use this feature as long as it's hidden. Do we want to keep it this way?

@klint klint mentioned this issue Oct 7, 2019
Closed
@sblatz
Copy link
Contributor Author

sblatz commented Oct 7, 2019 •
edited
Loading

@sv-ohorvath on Android 5&6 are you able to ever see the "Open with..." "(Private) Firefox Preview"? (before a default browser is set and you're opening a link)

@sv-ohorvath
Copy link
Contributor

@sv-ohorvath on Android 5&6 are you able to ever see the "Open with..." "(Private) Firefox Preview"? (before a default browser is set and you're opening a link)

@sblatz Yes, you can use the "Open with Private FP" function that way. The downside is you can't switch back to open in NBM unless you clear the app data/preferences from system settings.

@sblatz
Copy link
Contributor Author

sblatz commented Oct 8, 2019

@sv-ohorvath I'm going to file a follow-up ticket for those cases, so this ticket doesn't rot, and since it will work for most of our users. We will need UX to design a way for it to work on those other versions.

@sblatz sblatz mentioned this issue Oct 8, 2019
Closed
@sblatz
Copy link
Contributor Author

sblatz commented Oct 8, 2019

I filed #5870.

@sv-ohorvath I'm closing this since we have that to track the 5&6 issue. Let's file follow-ups for any future bugs on this :)

@sblatz sblatz closed this as completed Oct 8, 2019
Fenix Sprint Kanban automation moved this from In Progress to Sprint 10.1 Done Oct 8, 2019
@sv-ohorvath sv-ohorvath added the eng:qa:verified QA Verified label Oct 9, 2019
This was referenced Sep 1, 2020
Closed
Closed
Closed
@liuche liuche mentioned this issue Sep 17, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
E8 Estimation Point: about 8 days eng:qa:verified QA Verified Feature:PrivateBrowsing
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
2 participants
@sv-ohorvath @sblatz