This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #514 & #5742: Updates "launch links in private tab" functionality #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5721 +/- ##
=========================================
Coverage ? 14.43%
Complexity ? 322
=========================================
Files ? 256
Lines ? 10500
Branches ? 1530
=========================================
Hits ? 1516
Misses ? 8858
Partials ? 126
Continue to review full report at Codecov.
|
sblatz
added
pr:work-in-progress
sblatz
force-pushed
the
mess-with-private-mode-intents
branch
7 times, most recently
from
f1b6c16
to
ec84796
Compare
sblatz
removed
pr:do-not-land
pr:work-in-progress
sblatz
force-pushed
the
mess-with-private-mode-intents
branch
from
ec84796
to
2795a32
Compare
sblatz
force-pushed
the
mess-with-private-mode-intents
branch
from
2795a32
to
b1d65f3
Compare
sblatz
changed the title
…n private tab" functionality
sblatz
force-pushed
the
mess-with-private-mode-intents
branch
from
b1d65f3
to
ae9e2ec
Compare
severinrudie
reviewed
Oct 3, 2019
| @@ -123,6 +123,54 @@ | |||
| android:resource="@mipmap/ic_launcher" /> | |||
| </activity> | |||
|
|
|||
| <activity-alias | |||
There was a problem hiding this comment.
Nit: this would be a good place for a small comment explaining why we need this alias.
Comment on lines
+50
to
+55
| if (didLaunchPrivateLink && Browsers.all(this).isDefaultBrowser) { | ||
| this.settings().openLinksInAPrivateTab = true | ||
| } else if (!Browsers.all(this).isDefaultBrowser) { | ||
| /* If the user has unset us as the default browser, unset alwaysOpenInPrivateMode */ | ||
| this.settings().openLinksInAPrivateTab = false | ||
| } |
There was a problem hiding this comment.
Double checking because I'm not sure: would this properly handle the following case?
- User launches app in normal mode
- App is default browser
- User toggles openLinksInAPrivateTab
- App is backgrounded (but not destroyed)
- A third party link is opened
There was a problem hiding this comment.
I just tested and it opens the link in private mode as expected :)
app/src/main/java/org/mozilla/fenix/settings/DefaultBrowserFragment.kt
Outdated
Show resolved
Hide resolved
severinrudie
approved these changes
Oct 3, 2019
| android:paddingEnd="?android:attr/scrollbarSize"> | ||
|
|
||
| <LinearLayout | ||
| android:id="@android:id/widget_frame" |
There was a problem hiding this comment.
I'm not clear on exactly how this works, would it still function as a FrameLayout? They're somewhat less expensive to inflate.
sblatz
force-pushed
the
mess-with-private-mode-intents
branch
from
0a74773
to
3a73344
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR: