Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Beta round icon is square #6255

Closed
NotWoods opened this issue Oct 24, 2019 · 10 comments
Closed

[Bug] Beta round icon is square #6255

NotWoods opened this issue Oct 24, 2019 · 10 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. good first issue Good for newcomers Hacktoberfest Highlights issues for Hacktoberfest contributors to help us!
Milestone

Comments

@NotWoods
Copy link
Contributor

NotWoods commented Oct 24, 2019

Related to #2059. The roundIcon asset in fenixBeta needs to be switched with a round image.

Icon assets

┆Issue is synchronized with this Jira Task

@NotWoods NotWoods added 🐞 bug Crashes, Something isn't working, .. good first issue Good for newcomers Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! labels Oct 24, 2019
@daphliu-zz
Copy link
Contributor

I would like to take on this!

@sv-ohorvath
Copy link
Contributor

@NotWoods @daphliu I can't build a beta version locally due to this error: https://www.screencast.com/t/r2yJWWBZ

@pfieffer
Copy link
Contributor

pfieffer commented Nov 1, 2019

@sv-ohorvath Like the error suggests, you can not use - (hyphen character) in your resource name. You have named the icon ic_launcher-round. It should have been ic_launcher_round

@sv-ohorvath
Copy link
Contributor

@sv-ohorvath Like the error suggests, you can not use - (hyphen character) in your resource name. You have named the icon ic_launcher-round. It should have been ic_launcher_round

I didn't do that :) I'm just trying to build the apk to test this and this is blocking me.

@NotWoods
Copy link
Contributor Author

NotWoods commented Nov 1, 2019

Whoops, looks like the files in the zip had the wrong naming. I'll follow up and fix the file names.

NotWoods added a commit to NotWoods/fenix that referenced this issue Nov 2, 2019
sblatz pushed a commit that referenced this issue Nov 8, 2019
@sblatz sblatz added this to the v3.1 milestone Nov 8, 2019
@sv-ohorvath
Copy link
Contributor

@NotWoods I installed the beta app on a Nexus 5, API 22 emulator and the launcher icon is still square, same for Nightly. https://www.screencast.com/t/kLuLJ7AxHIRZ
What am I doing wrong?

@sv-ohorvath sv-ohorvath removed the eng:qa:needed QA Needed label Nov 12, 2019
@NotWoods
Copy link
Contributor Author

@sv-ohorvath Round icons only appear on Android 7.1

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Nov 20, 2019

@NotWoods This is from a Nokia 6 (Android 7.1.1). Beta built today locally.
Screenshot_20191120-144711

@NotWoods
Copy link
Contributor Author

Can you test on a Pixel device with Android 7.1? It seems that round icons are dependent on the manufacturer, as nightly is also displayed with a square icon here. I know that Pixels use round icons but I'm not sure what other phones do.

@sv-ohorvath
Copy link
Contributor

Can you test on a Pixel device with Android 7.1? It seems that round icons are dependent on the manufacturer, as nightly is also displayed with a square icon here. I know that Pixels use round icons but I'm not sure what other phones do.

Pixel with 7.1 has a round icon. @NotWoods I'll close this if that's all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. good first issue Good for newcomers Hacktoberfest Highlights issues for Hacktoberfest contributors to help us!
Projects
None yet
Development

No branches or pull requests

6 participants