Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #6255 - Fix beta icon filenames #6407

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Nov 2, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

Codecov Report

Merging #6407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6407   +/-   ##
=========================================
  Coverage     16.51%   16.51%           
  Complexity      352      352           
=========================================
  Files           277      277           
  Lines         11144    11144           
  Branches       1596     1596           
=========================================
  Hits           1840     1840           
  Misses         9154     9154           
  Partials        150      150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35d6013...b4b3de1. Read the comment docs.

@sblatz sblatz merged commit f476c62 into mozilla-mobile:master Nov 8, 2019
@NotWoods NotWoods deleted the beta-name-fix branch January 25, 2020 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants