Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Suggestion: Provide "open tab" within the "No open tabs" pane #6607

Closed
darkwing opened this issue Nov 14, 2019 · 9 comments
Closed

Suggestion: Provide "open tab" within the "No open tabs" pane #6607

darkwing opened this issue Nov 14, 2019 · 9 comments
Assignees
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:HomeScreen feature request 🌟 New functionality and improvements
Projects

Comments

@darkwing
Copy link
Contributor

darkwing commented Nov 14, 2019

Why/User Benefit/User Problem

We currently show a "No open tabs" block when the user hasn't opened any tabs, but there's nothing actionable with that message. I think it would be nice for usability to show an "open a tab" icon, button, or text in that space so the user can act while their attention is focused there.

What/Requirements

Update from UX (@topotropic) Feb 18, 2020:

  • When a user doesn't have any open tabs we show a button with "New tab" below the empty state message.
  • Once a user tabs on the button, we launch the search view.
  • See attached screenshot for specs

grafik

┆Issue is synchronized with this Jira Task

@darkwing darkwing added the feature request 🌟 New functionality and improvements label Nov 14, 2019
@brampitoyo
Copy link

@darkwing do you have a screenshot of what this pane looks like, and where we can find it?

@topotropic do you think we need to provide an “open a tab” action if the pane says “No open tabs”?

@brampitoyo
Copy link

@darkwing Sorry, I now realise that this pane exists in our homescreen. I wonder @topotropic whether this problem will be solved when we have the new tab tray?

@brampitoyo brampitoyo added this to Content Consumption in Workflow Feb 5, 2020
@brampitoyo brampitoyo moved this from Content Consumption to App Navigation in Workflow Feb 5, 2020
@mcarare
Copy link
Contributor

mcarare commented Feb 17, 2020

We already have an "open tab" button that is next to the menu button in the home screen.
And, as I remember, there was a "+" button in the open tabs section, but it was intentionally moved to the bottom bar according to #561

@topotropic
Copy link

@mcarare I have a design proposal for this, will update the issue once it's ready.

@topotropic topotropic added eng:ready Ready for engineering and removed needs:UX-feedback Needs UX Feedback labels Feb 18, 2020
@mcarare mcarare self-assigned this Feb 25, 2020
@mcarare mcarare moved this from App Navigation to Doing in Workflow Feb 25, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 25, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 25, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 25, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 28, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Feb 28, 2020
boek pushed a commit that referenced this issue Feb 28, 2020
@boek boek added the eng:qa:needed QA Needed label Feb 28, 2020
@KazaHesto
Copy link

The text colour becomes white when the theme is set to dark yet the button colour doesn't change, is this intentional?
Screenshot_20200302-080126

@brampitoyo
Copy link

@KazaHesto This is unintentional. The button style should be similar to other buttons in dark theme. Not the bright purple ones, but the ones in slightly lighter grey.

@sv-sdeiac
Copy link

Verified as fixed using the latest version of Firefox Preview Nightly 3/2 #20620607.

Devices:

  • Motorola Moto G6 (Android 8);
  • Samsung Galaxy Note 8 (Android 9);
  • Google Pixel 3 (Android Q).

Workflow automation moved this from Doing to Done Mar 2, 2020
@sv-sdeiac sv-sdeiac removed the eng:qa:needed QA Needed label Mar 2, 2020
@sv-sdeiac sv-sdeiac added the eng:qa:verified QA Verified label Mar 2, 2020
@ekager
Copy link
Contributor

ekager commented Mar 2, 2020

I don't think this is fixed yet on my device 🤔

@ekager ekager reopened this Mar 2, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 3, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 3, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 3, 2020
mcarare pushed a commit to mcarare/fenix that referenced this issue Mar 3, 2020
ekager pushed a commit to ekager/fenix that referenced this issue Mar 3, 2020
ekager pushed a commit to ekager/fenix that referenced this issue Mar 3, 2020
@sv-sdeiac
Copy link

Verified as fixed on the latest version of Firefox Preview Nightly 3/4 #20640606.

Devices: Samsung Galaxy Tab S3 (Android 8). Due to that, I'll close this ticket, thanks.

gmierz pushed a commit to gmierz/fenix that referenced this issue Mar 5, 2020
gmierz pushed a commit to gmierz/fenix that referenced this issue Mar 5, 2020
gmierz pushed a commit to gmierz/fenix that referenced this issue Mar 5, 2020
gmierz pushed a commit to gmierz/fenix that referenced this issue Mar 5, 2020
@liuche liuche mentioned this issue Mar 12, 2020
32 tasks
@liuche liuche mentioned this issue Mar 24, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:HomeScreen feature request 🌟 New functionality and improvements
Projects
No open projects
Workflow
  
Done
Development

No branches or pull requests

9 participants