Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add a favorite sites to the homescreen #6758

Closed
3 tasks done
boek opened this issue Nov 22, 2019 · 7 comments
Closed
3 tasks done

Add a favorite sites to the homescreen #6758

boek opened this issue Nov 22, 2019 · 7 comments
Assignees
@gabrielluong
Labels
E8 Estimation Point: about 8 days eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page needs:l10n Has strings that will require translation from the l10n team

Comments

@boek
Copy link
Contributor

boek commented Nov 22, 2019 •
edited by data-sync-user

User Story

As a user, I want to be able to explicitly add one of my favorite sites to the homescreen, so I can get to my frequently used sites faster.

What/Requirements

  • I can add a new website to my top sites

Acceptance Criteria (how do I know when I’m done?)

  • I can successfully add a new top site or know why I am unable to
  • I can measure how often people try to add new top sites

Estimation may change after we come up with a solution to replacing existing top sites.

┆Issue is synchronized with this Jira Task
@boek boek added feature request 🌟 New functionality and improvements E8 Estimation Point: about 8 days Feature:Shortcuts Top Sites/Topsites on the Firefox home page labels Nov 22, 2019
@boek
Copy link
Contributor Author

boek commented Nov 22, 2019

parent: #6190

@vesta0 vesta0 mentioned this issue Dec 5, 2019
Closed
15 tasks
@liuche liuche added 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Dec 6, 2019
@liuche liuche added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Dec 6, 2019
@liuche
Copy link
Contributor

liuche commented Dec 6, 2019

Adding waiting label, as the UX is pretty much done.

@gabrielluong gabrielluong self-assigned this Dec 9, 2019
@boek boek added the needs:l10n Has strings that will require translation from the l10n team label Dec 9, 2019
@liuche liuche removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Dec 12, 2019
@bifleming bifleming added the must label Dec 13, 2019
@vesta0 vesta0 changed the title As a user, I want to be able to explicitly add one of my favorite sites to the homescreen Add a favorite sites to the homescreen Dec 19, 2019
@vesta0 vesta0 removed the feature request 🌟 New functionality and improvements label Dec 19, 2019
@gabrielluong gabrielluong mentioned this issue Dec 19, 2019
Closed
@gabrielluong
Copy link
Member

This is currently blocked by mozilla-mobile/android-components#5315, which will be landing soon. The added top sites storage in AC allows us to add and remove pinned top sites.

gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 30, 2019
@gabrielluong
For mozilla-mobile#6758: Part 1: Add new strings for top sites feature
2de46e3
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 30, 2019
@gabrielluong
For mozilla-mobile#6758: Part 2: Add AC dependencies for top sites fe…
756e39b 
…ature
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 30, 2019
@gabrielluong
For mozilla-mobile#6758: Part 3: Add TopSiteStorage observable around…
4feffc4 
… AC's TopSiteStorage

This follows the existing pattern around TabCollectionStorage.
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 30, 2019
@gabrielluong
For mozilla-mobile#6758: Part 4: Implement "Add to Firefox Home" tool…
4b0a398 
…bar menu

- The "Add to Firefox Home" menu item adds a top site to the top site storage.
- Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController
since there are multiple menu items that need to show a FenixSnackbar.
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 30, 2019
@gabrielluong
For mozilla-mobile#6758: Part 5: Add top sites to the HomeFragmentStore
fbaece1
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 30, 2019
@gabrielluong
For mozilla-mobile#6758: Part 6: Add top site view
90bb03d
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 31, 2019
@gabrielluong
For mozilla-mobile#6758: Part 1: Add new strings for top sites feature
431eb8b
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 31, 2019
@gabrielluong
For mozilla-mobile#6758: Part 2: Add AC dependencies for top sites fe…
0f30cd6 
…ature
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 31, 2019
@gabrielluong
For mozilla-mobile#6758: Part 3: Add TopSiteStorage observable around…
8dccc81 
… AC's TopSiteStorage

This follows the existing pattern around TabCollectionStorage.
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Dec 31, 2019
@gabrielluong
For mozilla-mobile#6758: Part 4: Implement "Add to Firefox Home" tool…
ede9869 
…bar menu

- The "Add to Firefox Home" menu item adds a top site to the top site storage.
- Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController
since there are multiple menu items that need to show a FenixSnackbar.
@boek
Copy link
Contributor Author

boek commented Jan 23, 2020

@liuche got the branch all fixed up to land just trying to get CI to pass now 👍

@liuche
Copy link
Contributor

liuche commented Jan 23, 2020

oh my god so excited

gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 23, 2020
@gabrielluong
For mozilla-mobile#6758 - Part 1: Add new strings for top sites feature
4473831
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 23, 2020
@gabrielluong
For mozilla-mobile#6758 - Part 2: Add AC dependencies for top sites f…
d3e84f5 
…eature
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 23, 2020
@gabrielluong
For mozilla-mobile#6758 - Part 3: Add TopSiteStorage wrapper around A…
8ad43e6 
…C's TopSiteStorage

This follows the existing pattern around TabCollectionStorage.
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 23, 2020
@gabrielluong
For mozilla-mobile#6758 - Part 4: Implement "Add to Firefox Home" bro…
8e5be96 
…wser menu item

- The "Add to Firefox Home" browser menu item adds a top site to the top site storage.
- Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController
since there are multiple menu items that need to show a FenixSnackbar.
- Adds metrics for the new browser menu item.
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 23, 2020
@gabrielluong
For mozilla-mobile#6758 - Part 5: Add top sites to the HomeFragmentStore
b63b55b
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 23, 2020
@gabrielluong
For mozilla-mobile#6758 - Part 6: Add top site view
9cc02ef
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 23, 2020
@gabrielluong
For mozilla-mobile#6758 - Part 7: Add menu for opening a top site in …
b8d60f9 
…private tab and removing a top site
boek pushed a commit to gabrielluong/fenix that referenced this issue Jan 24, 2020
@gabrielluong @boek
For mozilla-mobile#6758 - Part 1: Add new strings for top sites feature
d061745
boek pushed a commit to gabrielluong/fenix that referenced this issue Jan 24, 2020
@gabrielluong @boek
For mozilla-mobile#6758 - Part 2: Add AC dependencies for top sites f…
a19901b 
…eature
boek pushed a commit to gabrielluong/fenix that referenced this issue Jan 24, 2020
@gabrielluong @boek
For mozilla-mobile#6758 - Part 3: Add TopSiteStorage wrapper around A…
42272a7 
…C's TopSiteStorage

This follows the existing pattern around TabCollectionStorage.
boek pushed a commit to gabrielluong/fenix that referenced this issue Jan 24, 2020
@gabrielluong @boek
For mozilla-mobile#6758 - Part 4: Implement "Add to Firefox Home" bro…
b89864b 
…wser menu item

- The "Add to Firefox Home" browser menu item adds a top site to the top site storage.
- Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController
since there are multiple menu items that need to show a FenixSnackbar.
- Adds metrics for the new browser menu item.
boek pushed a commit to gabrielluong/fenix that referenced this issue Jan 24, 2020
@gabrielluong @boek
For mozilla-mobile#6758 - Part 5: Add top sites to the HomeFragmentStore
e5b6151
boek pushed a commit to gabrielluong/fenix that referenced this issue Jan 24, 2020
@gabrielluong @boek
For mozilla-mobile#6758 - Part 6: Add top site view
8d60925
boek pushed a commit to gabrielluong/fenix that referenced this issue Jan 24, 2020
@gabrielluong @boek
For mozilla-mobile#6758 - Part 7: Add menu for opening a top site in …
a7a5937 
…private tab and removing a top site
boek pushed a commit that referenced this issue Jan 24, 2020
@gabrielluong @boek
For #6758 - Part 1: Add new strings for top sites feature
0a856d9
boek pushed a commit that referenced this issue Jan 24, 2020
@gabrielluong @boek
For #6758 - Part 2: Add AC dependencies for top sites feature
584b270
boek pushed a commit that referenced this issue Jan 24, 2020
@gabrielluong @boek
For #6758 - Part 3: Add TopSiteStorage wrapper around AC's TopSiteSto…
9ddf93e 
…rage

This follows the existing pattern around TabCollectionStorage.
boek pushed a commit that referenced this issue Jan 24, 2020
@gabrielluong @boek
For #6758 - Part 4: Implement "Add to Firefox Home" browser menu item
e1863dd 
- The "Add to Firefox Home" browser menu item adds a top site to the top site storage.
- Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController
since there are multiple menu items that need to show a FenixSnackbar.
- Adds metrics for the new browser menu item.
boek pushed a commit that referenced this issue Jan 24, 2020
@gabrielluong @boek
For #6758 - Part 5: Add top sites to the HomeFragmentStore
f68f89f
boek pushed a commit that referenced this issue Jan 24, 2020
@gabrielluong @boek
For #6758 - Part 6: Add top site view
9ecb67e
boek pushed a commit that referenced this issue Jan 24, 2020
@gabrielluong @boek
For #6758 - Part 7: Add menu for opening a top site in private tab an…
192eecd 
…d removing a top site
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Jan 25, 2020
@sv-sdeiac
Copy link

Verified as fixed using the latest version of Firefox Preview Nightly 1/28 #20280606.
Devices:

  • Nokia 6 (Android 7.1.1);
  • OnePlus 5T (Android 9).

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
E8 Estimation Point: about 8 days eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page needs:l10n Has strings that will require translation from the l10n team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@liuche @gabrielluong @boek @sv-sdeiac @vesta0 @bifleming