This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add a favorite sites to the homescreen #6758
Labels
E8
Estimation Point: about 8 days
eng:qa:verified
QA Verified
Feature:Shortcuts
Top Sites/Topsites on the Firefox home page
needs:l10n
Has strings that will require translation from the l10n team
Comments
parent: #6190 |
Adding waiting label, as the UX is pretty much done. |
This is currently blocked by mozilla-mobile/android-components#5315, which will be landing soon. The added top sites storage in AC allows us to add and remove pinned top sites. |
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 30, 2019
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 30, 2019
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 30, 2019
… AC's TopSiteStorage This follows the existing pattern around TabCollectionStorage.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 30, 2019
…bar menu - The "Add to Firefox Home" menu item adds a top site to the top site storage. - Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController since there are multiple menu items that need to show a FenixSnackbar.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 30, 2019
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 30, 2019
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 31, 2019
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 31, 2019
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 31, 2019
… AC's TopSiteStorage This follows the existing pattern around TabCollectionStorage.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Dec 31, 2019
…bar menu - The "Add to Firefox Home" menu item adds a top site to the top site storage. - Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController since there are multiple menu items that need to show a FenixSnackbar.
@liuche got the branch all fixed up to land just trying to get CI to pass now 👍 |
oh my god so excited |
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Jan 23, 2020
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Jan 23, 2020
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Jan 23, 2020
…C's TopSiteStorage This follows the existing pattern around TabCollectionStorage.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Jan 23, 2020
…wser menu item - The "Add to Firefox Home" browser menu item adds a top site to the top site storage. - Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController since there are multiple menu items that need to show a FenixSnackbar. - Adds metrics for the new browser menu item.
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Jan 23, 2020
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Jan 23, 2020
gabrielluong
added a commit
to gabrielluong/fenix
that referenced
this issue
Jan 23, 2020
…private tab and removing a top site
boek
pushed a commit
to gabrielluong/fenix
that referenced
this issue
Jan 24, 2020
boek
pushed a commit
to gabrielluong/fenix
that referenced
this issue
Jan 24, 2020
boek
pushed a commit
to gabrielluong/fenix
that referenced
this issue
Jan 24, 2020
…C's TopSiteStorage This follows the existing pattern around TabCollectionStorage.
boek
pushed a commit
to gabrielluong/fenix
that referenced
this issue
Jan 24, 2020
…wser menu item - The "Add to Firefox Home" browser menu item adds a top site to the top site storage. - Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController since there are multiple menu items that need to show a FenixSnackbar. - Adds metrics for the new browser menu item.
boek
pushed a commit
to gabrielluong/fenix
that referenced
this issue
Jan 24, 2020
boek
pushed a commit
to gabrielluong/fenix
that referenced
this issue
Jan 24, 2020
boek
pushed a commit
to gabrielluong/fenix
that referenced
this issue
Jan 24, 2020
…private tab and removing a top site
boek
pushed a commit
that referenced
this issue
Jan 24, 2020
boek
pushed a commit
that referenced
this issue
Jan 24, 2020
boek
pushed a commit
that referenced
this issue
Jan 24, 2020
…rage This follows the existing pattern around TabCollectionStorage.
boek
pushed a commit
that referenced
this issue
Jan 24, 2020
- The "Add to Firefox Home" browser menu item adds a top site to the top site storage. - Refactors the FenixSnackbar from BaseBrowserFragment into BrowserToolbarController since there are multiple menu items that need to show a FenixSnackbar. - Adds metrics for the new browser menu item.
boek
pushed a commit
that referenced
this issue
Jan 24, 2020
boek
pushed a commit
that referenced
this issue
Jan 24, 2020
Verified as fixed using the latest version of Firefox Preview Nightly 1/28 #20280606.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
E8
Estimation Point: about 8 days
eng:qa:verified
QA Verified
Feature:Shortcuts
Top Sites/Topsites on the Firefox home page
needs:l10n
Has strings that will require translation from the l10n team
User Story
As a user, I want to be able to explicitly add one of my favorite sites to the homescreen, so I can get to my frequently used sites faster.
What/Requirements
Acceptance Criteria (how do I know when I’m done?)
Estimation may change after we come up with a solution to replacing existing top sites.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: