Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] missing padding in download button, inconsistent button styling #7219

Closed
cadeyrn opened this issue Dec 16, 2019 · 4 comments
Closed

[Bug] missing padding in download button, inconsistent button styling #7219

cadeyrn opened this issue Dec 16, 2019 · 4 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, ..
Milestone
v3.1

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Dec 16, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. download a file

Expected behavior

same styling for download and open button.

Actual behavior

The download button has no padding on the left and the right, also the download button has a different color than the open button after the download.

Screenshot_20191212-235041
Screenshot_20191212-235031

Device information

  • Android device: OnePlus 7T Pro McLaren Edition with Android 10
  • Fenix version: Firefox Preview 3.0.0 and master branch revision 90c7751

┆Issue is synchronized with this Jira Task
@cadeyrn cadeyrn added the 🐞 bug Crashes, Something isn't working, .. label Dec 16, 2019
@ekager ekager self-assigned this Dec 16, 2019
ekager added a commit to ekager/fenix that referenced this issue Dec 16, 2019
@ekager
For mozilla-mobile#7219 - Use accent color for downloads dialog posit…
d5eb494 
…ive button
ekager added a commit to ekager/fenix that referenced this issue Dec 16, 2019
@ekager
For mozilla-mobile#7219 - Fixes gap beneath download notification dialog
f4419bd
ekager added a commit to ekager/fenix that referenced this issue Dec 17, 2019
@ekager
For mozilla-mobile#7219 - Use accent color for downloads dialog posit…
aff2c48 
…ive button
ekager added a commit to ekager/fenix that referenced this issue Dec 17, 2019
@ekager
For mozilla-mobile#7219 - Fixes gap beneath download notification dialog
ce85e8f
sblatz pushed a commit that referenced this issue Dec 18, 2019
@ekager @sblatz
For #7219 - Polish Download Notification Dialog. (#7224)
5ac79f5 
* For #7219 - Use accent color for downloads dialog positive button

* For #7219 - Fixes gap beneath download notification dialog

* switch to setimageresource
@sblatz sblatz added the eng:qa:needed QA Needed label Dec 18, 2019
@sblatz sblatz added this to the v3.1 milestone Dec 18, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 19, 2019

Hi, verified as fixed on the latest Nightly build #13530608 from 12/19 using the following devices:
• Google Pixel 3a (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

►Screenshots
black

white

@ekager - Seems like the "Download completed" context menu is larger than the "Download" confirmation context menu.
Please review and let me know if I should open a new issue. ☺️

@AndiAJ AndiAJ closed this as completed Dec 19, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Dec 19, 2019
@cadeyrn
Copy link
Contributor Author

cadeyrn commented Dec 19, 2019 •
edited
Loading

@AndiAJ

verified as fixed

In your screenshots the padding of the download button ("Herunterladen") is still missing, only the color is fixed (and #7220 seems to be fixed :) ). 🤔

@AndiAJ AndiAJ removed the eng:qa:verified QA Verified label Dec 19, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 19, 2019

As per @cadeyrn 's remark I'll re-open this issue.

Sorry for the inconvenience.

@AndiAJ AndiAJ reopened this Dec 19, 2019
psymoon added a commit that referenced this issue Dec 20, 2019
@psymoon @ekager
Add Add-on Manager boilerplate and initial add-on integration (#7280)
6251fec 
* For perf-frontend-issues#16: switch device_config parameter for Nimbledroid to be Android7 (#6985)

* For perf-frontend-issues#16: specify device_config parameter to be 'android7' when running Nimbledroid tests. This will switch the tests from running Android5 to Android7, which is a better representation of our user's experience

* Ensure we can test with both Android5 and Android7

* For #7219 - Polish Download Notification Dialog. (#7224)

* For #7219 - Use accent color for downloads dialog positive button

* For #7219 - Fixes gap beneath download notification dialog

* switch to setimageresource

* Add Add-on Manager boilerplate and initial add-on integration

Co-authored-by: Emma Malysz <emalysz@mozilla.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
Amejia481 pushed a commit that referenced this issue Dec 23, 2019
@psymoon @ekager @Amejia481
Add Add-on Manager boilerplate and initial add-on integration (#7280)
2375c21 
* For perf-frontend-issues#16: switch device_config parameter for Nimbledroid to be Android7 (#6985)

* For perf-frontend-issues#16: specify device_config parameter to be 'android7' when running Nimbledroid tests. This will switch the tests from running Android5 to Android7, which is a better representation of our user's experience

* Ensure we can test with both Android5 and Android7

* For #7219 - Polish Download Notification Dialog. (#7224)

* For #7219 - Use accent color for downloads dialog positive button

* For #7219 - Fixes gap beneath download notification dialog

* switch to setimageresource

* Add Add-on Manager boilerplate and initial add-on integration

Co-authored-by: Emma Malysz <emalysz@mozilla.com>
Co-authored-by: Emily Kager <emilykager@gmail.com>
@cadeyrn
Copy link
Contributor Author

cadeyrn commented Dec 30, 2019

It's fixed in the current build. I guess mozilla-mobile/android-components#5328 was not yet included the last time.

@cadeyrn cadeyrn closed this as completed Dec 30, 2019
@cadeyrn cadeyrn mentioned this issue Aug 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, ..
Projects
None yet
Milestone
v3.1
Development

No branches or pull requests
4 participants
@cadeyrn @sblatz @ekager @AndiAJ