This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #7219 - Polish Download Notification Dialog. #7224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekager
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7224 +/- ##
===========================================
- Coverage 18.9% 18.9% -0.01%
Complexity 436 436
===========================================
Files 290 290
Lines 11312 11315 +3
Branches 1538 1538
===========================================
Hits 2139 2139
- Misses 9010 9013 +3
Partials 163 163
Continue to review full report at Codecov.
|
NotWoods
approved these changes
Dec 17, 2019
| download_notification_icon.setImageDrawable(context.getDrawable( | ||
| mozilla.components.feature.downloads.R.drawable.mozac_feature_download_ic_download_failed | ||
| )) | ||
| download_notification_icon.setImageDrawable( |
There was a problem hiding this comment.
nit: Since you have to fix a conflict here anyways...do you mind changing this to setImageResource? That should use AppCompatResources under the hood for the compat ImageView.
ekager
force-pushed
the
7219-accent-color-downloads
branch
from
f4419bd
to
ce85e8f
Compare
ekager
added
the
pr:needs-landing
psymoon
added a commit
that referenced
this pull request
Dec 20, 2019
* For perf-frontend-issues#16: switch device_config parameter for Nimbledroid to be Android7 (#6985) * For perf-frontend-issues#16: specify device_config parameter to be 'android7' when running Nimbledroid tests. This will switch the tests from running Android5 to Android7, which is a better representation of our user's experience * Ensure we can test with both Android5 and Android7 * For #7219 - Polish Download Notification Dialog. (#7224) * For #7219 - Use accent color for downloads dialog positive button * For #7219 - Fixes gap beneath download notification dialog * switch to setimageresource * Add Add-on Manager boilerplate and initial add-on integration Co-authored-by: Emma Malysz <emalysz@mozilla.com> Co-authored-by: Emily Kager <emilykager@gmail.com>
Amejia481
pushed a commit
that referenced
this pull request
Dec 23, 2019
* For perf-frontend-issues#16: switch device_config parameter for Nimbledroid to be Android7 (#6985) * For perf-frontend-issues#16: specify device_config parameter to be 'android7' when running Nimbledroid tests. This will switch the tests from running Android5 to Android7, which is a better representation of our user's experience * Ensure we can test with both Android5 and Android7 * For #7219 - Polish Download Notification Dialog. (#7224) * For #7219 - Use accent color for downloads dialog positive button * For #7219 - Fixes gap beneath download notification dialog * switch to setimageresource * Add Add-on Manager boilerplate and initial add-on integration Co-authored-by: Emma Malysz <emalysz@mozilla.com> Co-authored-by: Emily Kager <emilykager@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge
To download an APK when reviewing a PR: