Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Headers] Top header is disconnect from status bar wich is a shame #7456

Closed
Octoton opened this issue Jan 1, 2020 · 6 comments
Closed

[Headers] Top header is disconnect from status bar wich is a shame #7456

Octoton opened this issue Jan 1, 2020 · 6 comments
Assignees
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering
Projects

Comments

@Octoton
Copy link

Octoton commented Jan 1, 2020

The old firefox header bar was cleaner because it was one with the status bar.

To get the same visual appeal, the loading bar should be at the bottom and the dark one pixel line at the top of the header bar should be remove.

┆Issue is synchronized with this Jira Task

@Octoton
Copy link
Author

Octoton commented Jan 2, 2020

Old firefox:
Screenshot_20200102-193826_Firefox~2

New firefox loading:
Screenshot_20200102-193841_Firefox_Preview~2

New firefox dark one pixel line:
Screenshot_20200102-193938_Firefox_Preview~2

@sv-sdeiac
Copy link

@pocmo Can you take a view on this issue and let your opinion on it?

@Dunexus
Copy link

Dunexus commented Feb 3, 2020

The one pixel line is also visible at the bottom of the screen when using bottom toolbar even if it is less noticeable.

@NotWoods NotWoods added the needs:UX-feedback Needs UX Feedback label Feb 4, 2020
@brampitoyo
Copy link

Sorry. This is an issue that somehow we’ve overlooked.

When the toolbar is on top:

  • The loading bar should appear below the toolbar – same with Fennec
  • The one pixel line above the toolbar should not appear

When the toolbar is on the bottom, the current design is already correct.

@brampitoyo brampitoyo added eng:ready Ready for engineering and removed needs:UX-feedback Needs UX Feedback labels Feb 5, 2020
@brampitoyo brampitoyo added this to a11y in Polish Feb 5, 2020
@Dunexus
Copy link

Dunexus commented Feb 5, 2020

@brampitoyo When the toolbar is on the bottom, there is still a one pixel grey line above and under the toolbar.
onepxlines
I highlighted the left part of these grey lines in red.
I don't think bottom one is intended.

Also, this might be related to some alignment issues between the toolbar on webpage and homepage (see #8087)

@ekager ekager self-assigned this Feb 5, 2020
ekager added a commit to ekager/fenix that referenced this issue Feb 5, 2020
ekager added a commit to ekager/fenix that referenced this issue Feb 5, 2020
@ekager ekager added the eng:qa:needed QA Needed label Feb 5, 2020
@sv-sdeiac
Copy link

Verified as fixed using the latest version of Firefox Preview Nightly 2/6 #20370604.

Devices:

  • Nokia 6 (Android 7.1.1);
  • Samsung Galaxy (Android 9);
  • Google Pixel 3 (Android Q).

@sv-sdeiac sv-sdeiac added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 6, 2020
@darkwing darkwing moved this from a11y to Done in Polish Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering
Projects
No open projects
Development

No branches or pull requests

6 participants