Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] light theme back and home buttons are invisible when overlays are shown #7532

Closed
kbrosnan opened this issue Jan 8, 2020 · 3 comments
Closed

[Bug] light theme back and home buttons are invisible when overlays are shown #7532

kbrosnan opened this issue Jan 8, 2020 · 3 comments
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Themes Dark mode, light mode, private browsing mode help wanted Help wanted from a contributor. More complex than good first issue.

Comments

@kbrosnan
Copy link
Contributor

kbrosnan commented Jan 8, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  • Open a secure website or one that triggers tracking protection
  • tap the lock icon or the tracking protection icon

Expected behavior

  • back button and home button are visible

Actual behavior

  • back button and home button are invisible

Device information

  • Android device: Pixel 3 w/ Android 10
  • Fenix version: Nightly

┆Issue is synchronized with this Jira Task
@kbrosnan kbrosnan added 🐞 bug Crashes, Something isn't working, .. Feature:Themes Dark mode, light mode, private browsing mode labels Jan 8, 2020
@kbrosnan
Copy link
Contributor Author

kbrosnan commented Jan 8, 2020

Light theme

Screenshot_20200107-203257

Dark theme

Screenshot_20200107-203326

@mcarare
Copy link
Contributor

mcarare commented Jan 8, 2020

I cannot reproduce this on 2 other devices with Android 9.

@kbrosnan kbrosnan mentioned this issue Feb 10, 2020
Closed
@ekager ekager added eng:ready Ready for engineering help wanted Help wanted from a contributor. More complex than good first issue. labels Apr 18, 2020
@ekager ekager self-assigned this Jul 9, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 9, 2020
@ekager
For mozilla-mobile#11099 For mozilla-mobile#12189 For mozilla-mobile#…
035396a 
…7532 - Clean up bottom navigation bar colors
ekager added a commit to ekager/fenix that referenced this issue Jul 10, 2020
@ekager
For mozilla-mobile#11099 For mozilla-mobile#12189 For mozilla-mobile#…
95f705d 
…7532 - Clean up bottom navigation bar colors
ekager added a commit to ekager/fenix that referenced this issue Jul 13, 2020
@ekager
For mozilla-mobile#11099 For mozilla-mobile#12189 For mozilla-mobile#…
557f6fd 
…7532 - Clean up bottom navigation bar colors
ekager added a commit that referenced this issue Jul 13, 2020
@ekager
For #11099 For #12189 For #7532 - Clean up bottom navigation bar colors
88af736
@ekager ekager added the eng:qa:needed QA Needed label Jul 13, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 16, 2020

Hi, verified as fixed on the latest Nightly Build 200716 from 7/16 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

►Video
20200716-100156

@AndiAJ AndiAJ closed this as completed Jul 16, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 16, 2020
@liuche liuche mentioned this issue Jul 20, 2020
Closed
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Themes Dark mode, light mode, private browsing mode help wanted Help wanted from a contributor. More complex than good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kbrosnan @ekager @mcarare @AndiAJ