Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Navigation buttons are almost invisible with new tab tray and private mode #11099

Closed
B0pol opened this issue May 31, 2020 · 12 comments
Closed
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs

Comments

@B0pol
Copy link

B0pol commented May 31, 2020

Steps to reproduce

  1. enable new tab tray in secret settings
  2. Set white theme in settings
  3. Go to private mode (click on the button at the top left, don't just click on the icon in the tabs drawer)
    1. Expected behavior
      I can see the navigation buttons
    2. Actual behavior
      It's white on white:

      there is no problem with normal mode and dark theme

      or normal mode + white theme
    3. Device information
  • Android device: Android 9: Pocophone F1, /e/ 0.9 (fork of LineageOS 16.0), no google services but microG.
  • Fenix version: Nightly 200531 06:00. Still reproducible with Nightly 200622 06:01.

┆Issue is synchronized with this Jira Task

@B0pol B0pol added the 🐞 bug Crashes, Something isn't working, .. label May 31, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 31, 2020
@cadeyrn
Copy link
Contributor

cadeyrn commented May 31, 2020

Android device: 9

Maybe you should provide more information about your device such the vendor and model name because it doesn't seem to affect all devices. I can't confirm this issue on the OnePlus 7T Pro with Android 10.

@ghost
Copy link

ghost commented May 31, 2020

This is how it looks on my device, Motorola One Power, Android 10. Definitely the button are being shaded.
Screenshot_20200531-182654

@cadeyrn
Copy link
Contributor

cadeyrn commented May 31, 2020

@Ss1113 It seems that your builds does not yet contain #11010 ("Add white/dark BG for Android bottom bar (currently it has opacity)").

@ghost
Copy link

ghost commented Jun 1, 2020

@cadeyrn The issue is now not reproducible in normal mode after the latest Nightly however the buttons are shaded in white in Private browsing mode.

Device: Motorola One Power, Android 10.
Fenix: Nightly 200601 06:00.
Screenshot_20200601-133040

@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 1, 2020

Screenshot from OnePlus 7T Pro McLaren with Android 10:

Screenshot_20200601-101020

So it seems device specific and not Android specific since we both use Android 10.

@ghost
Copy link

ghost commented Jun 1, 2020

@cadeyrn Yeah, that seems to be the case since I'm not able to reproduce this on Realme C3, Android 10.

@yoasif
Copy link
Contributor

yoasif commented Jun 4, 2020

Also seeing this on Pixel 2 (Android 10).

signal-attachment-2020-06-04-152653

@Diana-Rus
Copy link

Diana-Rus commented Jun 22, 2020

Hi, reproducible with Sony Xperia Z5 (Android 7) and Samsung Galaxy S9 (Android 8) with Light theme, in normal and private tabs tray,Nightly 6/22.
With Google Pixel 3 XL (Android 9) the device button's are visible.

@B0pol
Copy link
Author

B0pol commented Jun 22, 2020

Android device: 9

Maybe you should provide more information about your device such the vendor and model name because it doesn't seem to affect all devices. I can't confirm this issue on the OnePlus 7T Pro with Android 10.

Pocophone F1, /e/ 0.9 (fork of LineageOS 16.0), no gapps but microG.

@cadeyrn
Copy link
Contributor

cadeyrn commented Jul 4, 2020

Do we already know the cause of this issue?

In the Firefox support another user reported this issue. He has a Honor 7 with Android 6.

@ghost
Copy link

ghost commented Jul 6, 2020

Still reproducing on Nightly 200704 18:05 in Private Browsing Mode.
Device: Motorola One Power, Android 10.

@ekager ekager self-assigned this Jul 9, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 9, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 10, 2020
ekager added a commit to ekager/fenix that referenced this issue Jul 13, 2020
@ekager ekager added the eng:qa:needed QA Needed label Jul 13, 2020
@Diana-Rus
Copy link

Hi, issue is fixed, now the android navigation bar has visible buttons for user with the devices on which i encountered them: Sony Xperia Z5 (Android 7) and Samsung Galaxy S9 (Android 8) which have had problems before with the navigation bar when tabs tray was opened.

Sony Xperia Z5 - GIF- Nav bar - Tabs tray - Dark mode,Light mode and Private mode

20200716-125220

Samsung Galaxy S9 - GIF- Nav bar - Tabs tray -Dark mode,Light mode and Private mode

20200716-125526

Note:

  • Even though the issue is fixed it seems that the navigation bar color is inconsistent on different devices/OS, when light mode is used, in both normal mode and private mode, can be seen in the added GIF's

@Diana-Rus Diana-Rus added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 16, 2020
@data-sync-user data-sync-user changed the title [Bug] Navigation buttons are almost invisible with new tab tray and private mode FNX-11964 ⁃ [Bug] Navigation buttons are almost invisible with new tab tray and private mode Jul 31, 2020
@data-sync-user data-sync-user changed the title FNX-11964 ⁃ [Bug] Navigation buttons are almost invisible with new tab tray and private mode FNX3-14388 ⁃ [Bug] Navigation buttons are almost invisible with new tab tray and private mode Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-14388 ⁃ [Bug] Navigation buttons are almost invisible with new tab tray and private mode FNX-11964 ⁃ [Bug] Navigation buttons are almost invisible with new tab tray and private mode Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-11964 ⁃ [Bug] Navigation buttons are almost invisible with new tab tray and private mode FNX2-13350 ⁃ [Bug] Navigation buttons are almost invisible with new tab tray and private mode Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-13350 ⁃ [Bug] Navigation buttons are almost invisible with new tab tray and private mode [Bug] Navigation buttons are almost invisible with new tab tray and private mode May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs
Projects
None yet
Development

No branches or pull requests

7 participants