Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Telemetry event for deleting a custom search engine is not sent #7881

Closed
ValentinTimisica opened this issue Jan 23, 2020 · 3 comments
Closed

[Bug] Telemetry event for deleting a custom search engine is not sent #7881

ValentinTimisica opened this issue Jan 23, 2020 · 3 comments
Assignees
@ValentinTimisica
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified

Comments

@ValentinTimisica
Copy link
Contributor

ValentinTimisica commented Jan 23, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  • Navigate to Settings -> Search
  • Have a custom search engine added
  • Tap on 3 dots icon from a custom search engine -> Select Delete

Expected behavior

  • Telemetry event (CustomEngineDeleted) should be send.

Actual behavior

  • No telemetry event is sent when a custom engine is deleted.

This is a follow up to #5884.

┆Issue is synchronized with this Jira Task
@ValentinTimisica ValentinTimisica added the 🐞 bug Crashes, Something isn't working, .. label Jan 23, 2020
@ValentinTimisica ValentinTimisica self-assigned this Jan 23, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 23, 2020
@ValentinTimisica ValentinTimisica mentioned this issue Jan 23, 2020
Closed
@ValentinTimisica ValentinTimisica removed the needs:triage Issue needs triage label Jan 23, 2020
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Jan 23, 2020
@ValentinTimisica
Fixes mozilla-mobile#7881: Send telemetry event when custom search en…
9b9733d 
…gine is deleted
liuche pushed a commit to ValentinTimisica/fenix that referenced this issue Jan 25, 2020
@ValentinTimisica @liuche
Fixes mozilla-mobile#7881: Send telemetry event when custom search en…
026d96c 
…gine is deleted
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Jan 27, 2020
@ValentinTimisica
Fixes mozilla-mobile#7881: Send telemetry event when custom search en…
9ee0693 
…gine is deleted
@ValentinTimisica
Copy link
Contributor Author

Reopen for QA.

@ValentinTimisica
Copy link
Contributor Author

Testing notes

@AndiAJ for this you need to verify that the "deleting a custom search engine" telemetry event (created in #5884) is sent properly.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Jan 28, 2020

Hi, verified as fixed on the latest Nightly Build #20280607 from 1/28 using a OnePlus A3 (Android 6.0.1)

✔️ Delete IMDB Custom search engine - Ping 342bbdb8-2e45-4262-bb12-e4b1cf65163f
✔️ Delete Twitch Custom search engine - Ping 305f5059-ad97-49d5-8ffa-402b09cfac18
✔️ Delete Vimeo Custom search engine - Ping 890b2260-c7b6-429a-8455-ecf23eb917dc

Logcat
Glean dashboard

@AndiAJ AndiAJ closed this as completed Jan 28, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ValentinTimisica ValentinTimisica

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndiAJ @ValentinTimisica