Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Private Browsing button state is not known in TalkBack #804

Closed
eeejay opened this issue Mar 2, 2019 · 1 comment
Closed

Private Browsing button state is not known in TalkBack #804

eeejay opened this issue Mar 2, 2019 · 1 comment
Assignees
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc.

Comments

@eeejay
Copy link
Contributor

eeejay commented Mar 2, 2019

Steps to reproduce

  1. With TalkBack on go to Private Browsing button. You will hear: "Enable Private Browsing, button"
  2. Activate button (double tap)
  3. Private browsing window appears, go to Private Browsing. You will hear "Enable Private Browsing, button".

Expected behavior

When in Private browsing, it should say "Disable Private Browsing, button".

Actual behavior

It says "Enable Private Browsing, button".

Device information

  • Android device: Pixel
  • Fenix version: master/nightly

Aside

We need to figure out a prominent way for TalkBack users to know they are in private browsing. Right now, they would need to check the state of this button or read the private browsing copy in the private browsing home screen.

That should probably be a followup issue.

┆Issue is synchronized with this Jira Task

@eeejay
Copy link
Contributor Author

eeejay commented Mar 5, 2019

Something that seems like a general usability thing, but is harder for TalkBack users: The private browsing button switches back and fourth between the private and non-private session. A user might expect "disabling" the private session would delete it. Instead it persists until the next time a user "enables" private browsing. Is this a feature or bug?

If its a feature maybe what we really need is a "enter/exit private browsing" instead of enable/disable. Don't know. That might help a bit for TalkBack users, but for sighted users that toggle-like button might still be confusing.

@pocmo pocmo added the access Accessibility: Talkback, HW keyboard/mouse, braile display etc. label Mar 5, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Mar 5, 2019
@sblatz sblatz added this to the Sprint 3-1 (Milestone 3) milestone Mar 8, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Mar 8, 2019
@sblatz sblatz closed this as completed in d6ebd88 Mar 8, 2019
@ghost ghost removed in progress labels Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
access Accessibility: Talkback, HW keyboard/mouse, braile display etc.
Projects
None yet
Development

No branches or pull requests

3 participants