[Bug] The same site can be added multiple times to the top sites

[sflorean]

Depends on three-dot menu redesign: #17796

Steps to reproduce

1. Browse any site(wikipedia.com).
2. Tap on 3dot menu and select "Add to Home screen".
3. Tap again on the 3dot menu and select "Add to Home screen".

Expected behavior

The "add to home screen" item will say "Remove from home screen" if the site has already been added.
The option is greyed out for the pages that are already added to the home screen /or a message is displayed that the page is already added.

Actual behavior

The same page can be added multiple times to the home screen.

Device information

• Android device: Sony Xperia Z5 Premium (Android 7.1.1), Samsung Note 8 (Android 9.0)
• Fenix version: Firefox Nightly 2/5 #20360607

┆Issue is synchronized with this Jira Task

[sflorean]

Reproducible also for Private browsing shortcut, from settings and from the private browsing pop-up.

[sv-sdeiac]

Notes:

• If you have multiple Top Sites from the same page, one of those shortcuts can't be deleted.

Device: Samsung Galaxy S8 (Android 9);
Build: Firefox Preview Nightly 2/7 #20380605.

[mcarare]

@topotropic How do we want to handle this?
Should we not show the option to add or should we notify that it already exists (text on the Snackbar instead of the confirmation one). IMO the last one is more user friendly. TY!

LE: And maybe a decision for #8312?

[brampitoyo]

@mcarare – @topotropic will make the final decision, but another potential solution would be to rename the menu item to “Remove from Top Sites”.

(Another question: will it be possible to do the same for the home screen, so we have a menu item called “Remove from Home screen”?)

[mcarare]

@brampitoyo There already is a "Remove" menu option for a top site, if that is what you are referring to.
I like your idea with renaming the menu option in the browser! 👍

[brampitoyo]

@mcarare Correct. Each top site, when long-pressed, shows a context menu with “Remove” in it. This is replicating the same functionality inside the main menu, when the top site is open.

Instead of removing the list item “Add to top sites”, or greying it out, we can rename it to “Remove from top sites”.

I’ll leave the decision to @topotropic :-)

[AmyYLee]

@topotropic to follow-up

[topotropic]

Yes, to what Bram said. Thanks!

[chrishernan]

Hello. Could I work on this issue please?

[stale]

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[nick-morhun]

@mcarare @Alexandru2909 Hello. Sorry, I'm not a part of this project or anything, just want to help. I still believe that the report is about the OS Home screen, not the Top Sites inside the browser. So you cannot fix the original issue.

[gabrielluong]

@mcarare @Alexandru2909 Hello. Sorry, I'm not a part of this project or anything, just want to help. I still believe that the report is about the OS Home screen, not the Top Sites inside the browser. So you cannot fix the original issue.

This seems sensible. I opened #23202 to track Home Screen.

[sflorean]

Verified as fixed on latest Nightly build (98.0a1) with OnePlus 9(Android 11).
"Remove from top sites" is displayed in Settings, for websites already added to Top Sites.