Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Create a Fenix Leanplum Attribute that tells us the app is Fenix #8172

Closed
st3fan opened this issue Feb 6, 2020 · 5 comments
Closed

Create a Fenix Leanplum Attribute that tells us the app is Fenix #8172

st3fan opened this issue Feb 6, 2020 · 5 comments
Assignees

Comments

@st3fan
Copy link
Contributor

st3fan commented Feb 6, 2020

Why/User Benefit/User Problem

Because of the application migration, the application could be Fennec or Fenix. This is a request to add a simple Fenix attribute to Leanplum that will tell us that the app is Fenix.

What/Requirements

A leanplum attribute Fenix that is always set to true.

Acceptance Criteria (how do I know when I’m done?)

┆Issue is synchronized with this Jira Task

@st3fan st3fan added the feature request 🌟 New functionality and improvements label Feb 6, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 6, 2020
@cbonacuse
Copy link

For additional context, adding the attribute will allow us in Leanplum to create an "event" which we can then track as a "conversion event" for a campaign. i.e. when we roll out Fenix to the Android release app, we will want to know how many users we were able to convert to the Fenix version of the app and we cannot do this by simply filtering on app version.

By having the attribute of 'Fenix' set to 'true', we will set up a Leanplum event (i.e. E_Updated_To_Fenix) that will be triggered in a users profile and we can track conversions in a campaign.

@vesta0 vesta0 added must Feature:Migration and removed feature request 🌟 New functionality and improvements needs:triage Issue needs triage labels Feb 6, 2020
@vesta0 vesta0 added this to Sprint Backlog in Fenix Sprint Kanban Feb 6, 2020
@ValentinTimisica ValentinTimisica self-assigned this Feb 7, 2020
@ValentinTimisica ValentinTimisica moved this from Sprint Backlog to In Progress in Fenix Sprint Kanban Feb 7, 2020
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Feb 7, 2020
@ValentinTimisica ValentinTimisica moved this from In Progress to In Dev Review in Fenix Sprint Kanban Feb 7, 2020
boek added a commit to ValentinTimisica/fenix that referenced this issue Feb 7, 2020
@lwa-moz
Copy link

lwa-moz commented Feb 11, 2020

@st3fan after speaking with @cbonacuse, it sounds like the Marketing team will also need a Leanplum event that corresponds to a user updating from Fennec to Fenix.

"Events" are used by the Marketing team as a means of determining campaign success. In this instance, that they have successfully encouraged a user to update to Fenix.

Additionally, events can be used to trigger additional campaigns, for instance an onboarding message sent to users after they update to Fenix.

Unfortunately, attributes cannot be used in this way. We will therefore need to create an event that fires when a user updates from Fennec to Fenix. Perhaps this event could be instrumented at the conclusion of the data migration flow?

ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Feb 11, 2020
ValentinTimisica pushed a commit to ValentinTimisica/fenix that referenced this issue Feb 11, 2020
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Feb 11, 2020
…lum event

This new event will be sent when the user has successfully migrated from Fennec
to Fenix.
This event will only be sent to Leanplum and not to the other telemetry
services like Glean or Adjust.
boek pushed a commit to ValentinTimisica/fenix that referenced this issue Feb 13, 2020
boek added a commit to ValentinTimisica/fenix that referenced this issue Feb 13, 2020
boek pushed a commit to ValentinTimisica/fenix that referenced this issue Feb 13, 2020
boek added a commit to ValentinTimisica/fenix that referenced this issue Feb 13, 2020
boek added a commit to ValentinTimisica/fenix that referenced this issue Feb 13, 2020
…lum event

This new event will be sent when the user has successfully migrated from Fennec
to Fenix.
This event will only be sent to Leanplum and not to the other telemetry
services like Glean or Adjust.
boek added a commit to ValentinTimisica/fenix that referenced this issue Feb 13, 2020
…lum event

This new event will be sent when the user has successfully migrated from Fennec
to Fenix.
This event will only be sent to Leanplum and not to the other telemetry
services like Glean or Adjust.
boek added a commit to ValentinTimisica/fenix that referenced this issue Feb 13, 2020
…lum event

This new event will be sent when the user has successfully migrated from Fennec
to Fenix.
This event will only be sent to Leanplum and not to the other telemetry
services like Glean or Adjust.

Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
boek added a commit that referenced this issue Feb 13, 2020
boek added a commit that referenced this issue Feb 13, 2020
This new event will be sent when the user has successfully migrated from Fennec
to Fenix.
This event will only be sent to Leanplum and not to the other telemetry
services like Glean or Adjust.

Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
@ValentinTimisica ValentinTimisica moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban Feb 18, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Feb 19, 2020

Hi, verified as fixed.

✔️ Fenix Nightly - Fenix Leanplum Attribute set to TRUE (Device ID 5152fa49-fbd5-43ac-8f45-9c7cecf4bf9a )
FenixNight

✔️ Fenix Beta v4.0.0-beta.1 - Fenix Leanplum Attribute set to TRUE (Device ID 39ec97f9-7cbd-43eb-9466-0956119cefb7 )
FeniBeta

✔️Performed manually a migration from Fennec to Fenix and the E_Fennec_To_Fenix_Migrated event was successfully created. (Device ID ca28e3cc-82c2-49c3-bad5-5a81b62a7e15)
migos

Please note that this event was generated in the Firefox Nightly section of Leanplum.
image

@AndiAJ AndiAJ closed this as completed Feb 19, 2020
@project-bot project-bot bot moved this from Ready for QA to Sprint 20.2 Done in Fenix Sprint Kanban Feb 19, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 19, 2020
@project-bot project-bot bot moved this from Sprint 20.2 Done to Sprint Backlog in Fenix Sprint Kanban Feb 19, 2020
@sblatz sblatz moved this from Sprint Backlog to Sprint 20.2 Done in Fenix Sprint Kanban Feb 19, 2020
@cbonacuse
Copy link

Hello! I know this is now closed, but after looking in Leanplum at the Nightly users, it appears that the fenix attribute did not get applied retroactively to users who were updated to Fenix prior to the attribute being created. Was this expected?

According to this dashboard, the earliest version of Nightly (with the date/timestamp versioning) that shows fenix (or Fenix) is TRUE is 2/14.

@ValentinTimisica
Copy link
Contributor

Yes, this is expected. We added a new attribute in code which only produces effects for the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants