Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Meta Toolbar] Remove feature flag for dynamic bottom toolbar #8775

Closed
4 of 6 tasks
sblatz opened this issue Feb 26, 2020 · 4 comments
Closed
4 of 6 tasks

[Meta Toolbar] Remove feature flag for dynamic bottom toolbar #8775

sblatz opened this issue Feb 26, 2020 · 4 comments
Labels
Feature:Browsing Issues related to browsing experience, browser navigation, not web issues Feature:Toolbar Address bar, see also Feature:Search

Comments

@sblatz
Copy link
Contributor

sblatz commented Feb 26, 2020

We have now enabled dynamic bottom toolbar for nightly/debug builds. Filing this so we eventually enable it for all builds.

These three issues are the most critical to verify before landing this in a wider release:

Top Toolbar Issues

  • Note these currently exist in release.

cc @vesta0 to track this :)

┆Issue is synchronized with this Jira Task

@sblatz sblatz added the Feature:Browsing Issues related to browsing experience, browser navigation, not web issues label Feb 26, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 26, 2020
@kbrosnan kbrosnan added Feature:Toolbar Address bar, see also Feature:Search and removed Feature:Toolbar labels Mar 3, 2020
@liuche
Copy link
Contributor

liuche commented Apr 24, 2020

I'll be cutting the 5.0 release on Monday 4/27 with the new AC release, @sblatz is this ready to be turned on? I believe @AmyYLee will meet and go over this with you next week to decide if we want it in the Fennec/Fenix build. In the meantime, if there aren't any large outstanding issues, @vesta0 wanted to get this onto Firefox Preview.

@sblatz
Copy link
Contributor Author

sblatz commented Apr 27, 2020

As discussed on Slack, I think we should actually block this feature flag on these two issues (caused by the same underlying GV bug):

#10073
and
#10045

@sblatz sblatz added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Apr 27, 2020
@eliserichards eliserichards removed the needs:triage Issue needs triage label May 1, 2020
@liuche liuche removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jun 1, 2020
@liuche liuche changed the title Remove feature flag for dynamic bottom toolbar [Meta Toolbar] Remove feature flag for dynamic bottom toolbar Jun 3, 2020
liuche added a commit that referenced this issue Jun 10, 2020
Co-authored-by: liuche <liuche@mozilla.com>
@liuche
Copy link
Contributor

liuche commented Jun 17, 2020

We decided that we'll remove the feature flag for 5.2 so we can get more testing on it, even though we really need #10477 to be fixed if we want to put this in The Release.

@liuche
Copy link
Contributor

liuche commented Jun 22, 2020

The remaining issue is not a release blocker.

@liuche liuche closed this as completed Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature:Browsing Issues related to browsing experience, browser navigation, not web issues Feature:Toolbar Address bar, see also Feature:Search
Projects
None yet
Development

No branches or pull requests

4 participants