Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Replace our TabCounter with the AC version #8791

Closed
ekager opened this issue Feb 26, 2020 · 1 comment
Closed

Replace our TabCounter with the AC version #8791

ekager opened this issue Feb 26, 2020 · 1 comment
Assignees
@eliserichards
Labels
eng:health Improve code health

Comments

@ekager
Copy link
Contributor

ekager commented Feb 26, 2020 •
edited by data-sync-user

In #8505 we replaced our tab counter icon with a more centered one that doesn't require as much customization on top of the AC code. I think we could now use the AC version of TabCounter and delete the Fenix-unique files. This ticket will need a bit of investigation to figure out if we are doing anything else custom here, and if we need to add anything to AC to use the correct icon/tinting.

┆Issue is synchronized with this Jira Task
@ekager ekager added the eng:health Improve code health label Feb 26, 2020
@ekager ekager mentioned this issue Feb 26, 2020
Closed
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 26, 2020
@ekager ekager mentioned this issue Feb 26, 2020
Merged
4 tasks
@gabrielluong gabrielluong self-assigned this Feb 26, 2020
@darkwing darkwing mentioned this issue Feb 28, 2020
Closed
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Mar 2, 2020
@gabrielluong
For mozilla-mobile#8791 - Replace TabCounter with the AC components
b93ff58
@csadilek csadilek mentioned this issue Oct 7, 2020
Closed
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Oct 8, 2020
@eliserichards eliserichards self-assigned this Oct 15, 2020
@eliserichards
Copy link
Contributor

AC docs: https://github.com/mozilla-mobile/android-components/tree/master/components/ui/tabcounter

@eliserichards eliserichards mentioned this issue Oct 16, 2020
Closed
3 tasks
This was referenced Oct 27, 2020
Closed
Merged
@eliserichards eliserichards mentioned this issue Nov 20, 2020
Merged
14 tasks
csadilek pushed a commit to eliserichards/fenix that referenced this issue Dec 3, 2020
@eliserichards @csadilek
Closes mozilla-mobile#8791: Use A-C tab counter and upgrade to 69.0.2…
42f3d82 
…0201203202830
csadilek pushed a commit to eliserichards/fenix that referenced this issue Dec 3, 2020
@eliserichards @csadilek
Closes mozilla-mobile#8791: Use A-C tab counter and upgrade to 69.0.2…
459b6c8 
…0201203202830

Also upgrades androidx workmanager to 2.4.0 in line with A-C.
csadilek pushed a commit to eliserichards/fenix that referenced this issue Dec 3, 2020
@eliserichards @csadilek
Closes mozilla-mobile#8791: Use A-C tab counter and upgrades to A-C 6…
ca33768 
…9.0.20201203202830

Upgrades to A-C 69.0.20201203202830 and addresses breaking changes:
- Upgrades androidx workmanager to 2.4.0 in line with A-C.
- RecordingDevicesNotificationFeature was removed
- SearchUseCases accept parent session ID instead of session itself
csadilek pushed a commit to eliserichards/fenix that referenced this issue Dec 3, 2020
@eliserichards @csadilek
Closes mozilla-mobile#8791: Use A-C tab counter and upgrades to A-C 6…
92ce997 
…9.0.20201203202830

Upgrades to A-C 69.0.20201203202830 and addresses breaking changes:
- Upgrades androidx workmanager to 2.4.0 in line with A-C.
- RecordingDevicesNotificationFeature was removed
- SearchUseCases accept parent session ID instead of session itself
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 4, 2021
@eliserichards @pkirakosyan
Closes mozilla-mobile#8791: Use A-C tab counter and upgrades to A-C 6…
a45dd08 
…9.0.20201203202830

Upgrades to A-C 69.0.20201203202830 and addresses breaking changes:
- Upgrades androidx workmanager to 2.4.0 in line with A-C.
- RecordingDevicesNotificationFeature was removed
- SearchUseCases accept parent session ID instead of session itself
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eliserichards eliserichards

Labels
eng:health Improve code health
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabrielluong @ekager @eliserichards