Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add isDefault Flag to default Top Site entries #9286

Closed
ekager opened this issue Mar 20, 2020 · 5 comments
Closed

Add isDefault Flag to default Top Site entries #9286

ekager opened this issue Mar 20, 2020 · 5 comments
Labels
eng:health Improve code health eng:ready Ready for engineering Feature:Shortcuts Top Sites/Topsites on the Firefox home page

Comments

@ekager
Copy link
Contributor

ekager commented Mar 20, 2020

Why/User Benefit/User Problem

Currently, on first install, we check the current locale and then add default top sites to the generic top sites storage. With an impending deadline, this was kind of a hack. Adding a flag would allow us to have better telemetry, be able to position them where we want them, and edit/change/remove those default top sites if necessary, ie when the locale or endpoint for these sites changes

What/Requirements

Will require AC work to edit the DB entry to contain a boolean like isDefault, and then use that flag in Fenix when adding default top sites on first install.

Acceptance Criteria (how do I know when I’m done?)

We can tell (for new users only :/ ) which are the default top sites for telemetry and for editing/changing those if needed

┆Issue is synchronized with this Jira Task

@ekager
Copy link
Contributor Author

ekager commented Mar 20, 2020

Opened mozilla-mobile/android-components#6331 for AC changes required

@gabrielluong
Copy link
Member

Opened mozilla-mobile/android-components#6331 for AC changes required

Taking on the AC changes. 👍

@vesta0 vesta0 added Feature:Shortcuts Top Sites/Topsites on the Firefox home page and removed needs:triage Issue needs triage feature request 🌟 New functionality and improvements labels Apr 28, 2020
@vesta0 vesta0 added this to Prioritized Eng Backlog in Fenix Sprint Kanban Apr 28, 2020
@liuche
Copy link
Contributor

liuche commented Apr 29, 2020

Looks like the AC changes are ready.

@liuche liuche added the eng:ready Ready for engineering label Apr 29, 2020
@eliserichards eliserichards removed the needs:ac Needs Android Component Work label May 6, 2020
@eliserichards eliserichards moved this from Prioritized Eng Backlog to Prioritized Backlog in Fenix Sprint Kanban May 6, 2020
@liuche liuche moved this from Prioritized Backlog to Sprint Backlog in Fenix Sprint Kanban May 11, 2020
@liuche
Copy link
Contributor

liuche commented May 11, 2020

This is the pre-req for updating the default top sites telemetry, and is done.

@liuche liuche closed this as completed May 11, 2020
@liuche liuche removed this from Sprint Backlog in Fenix Sprint Kanban May 11, 2020
@liuche
Copy link
Contributor

liuche commented May 11, 2020

@ekager will add the bug tracking the remaining work to the sprint backlog.

NotWoods added a commit to NotWoods/fenix that referenced this issue May 15, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue May 15, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue May 15, 2020
ekager pushed a commit to NotWoods/fenix that referenced this issue May 18, 2020
ekager pushed a commit that referenced this issue May 18, 2020
@liuche liuche mentioned this issue May 19, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:health Improve code health eng:ready Ready for engineering Feature:Shortcuts Top Sites/Topsites on the Firefox home page
Projects
None yet
Development

No branches or pull requests

5 participants