This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Add isDefault Flag to default Top Site entries #9286
Labels
eng:health
Improve code health
eng:ready
Ready for engineering
Feature:Shortcuts
Top Sites/Topsites on the Firefox home page
Comments
ekager
added
feature request 🌟
New functionality and improvements
needs:ac
Needs Android Component Work
eng:health
Improve code health
labels
Mar 20, 2020
This was referenced Mar 20, 2020
Opened mozilla-mobile/android-components#6331 for AC changes required |
Taking on the AC changes. 👍 |
vesta0
added
Feature:Shortcuts
Top Sites/Topsites on the Firefox home page
and removed
needs:triage
Issue needs triage
feature request 🌟
New functionality and improvements
labels
Apr 28, 2020
Looks like the AC changes are ready. |
eliserichards
moved this from Prioritized Eng Backlog
to Prioritized Backlog
in Fenix Sprint Kanban
May 6, 2020
This is the pre-req for updating the default top sites telemetry, and is done. |
@ekager will add the bug tracking the remaining work to the sprint backlog. |
NotWoods
added a commit
to NotWoods/fenix
that referenced
this issue
May 15, 2020
NotWoods
added a commit
to NotWoods/fenix
that referenced
this issue
May 15, 2020
NotWoods
added a commit
to NotWoods/fenix
that referenced
this issue
May 15, 2020
ekager
pushed a commit
to NotWoods/fenix
that referenced
this issue
May 18, 2020
ekager
pushed a commit
that referenced
this issue
May 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
eng:health
Improve code health
eng:ready
Ready for engineering
Feature:Shortcuts
Top Sites/Topsites on the Firefox home page
Why/User Benefit/User Problem
Currently, on first install, we check the current locale and then add default top sites to the generic top sites storage. With an impending deadline, this was kind of a hack. Adding a flag would allow us to have better telemetry, be able to position them where we want them, and edit/change/remove those default top sites if necessary, ie when the locale or endpoint for these sites changes
What/Requirements
Will require AC work to edit the DB entry to contain a boolean like
isDefault
, and then use that flag in Fenix when adding default top sites on first install.Acceptance Criteria (how do I know when I’m done?)
We can tell (for new users only :/ ) which are the default top sites for telemetry and for editing/changing those if needed
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: