Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] (regression) collection name is not correctly aligned #9496

Closed
cadeyrn opened this issue Mar 29, 2020 · 7 comments · Fixed by #9507
Closed

[Bug] (regression) collection name is not correctly aligned #9496

cadeyrn opened this issue Mar 29, 2020 · 7 comments · Fixed by #9507
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Collections S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Mar 29, 2020

Steps to reproduce

  1. make sure you have at least one collection
  2. open the Fenix start screen

Expected behavior

The collection name is vertically centered.

Actual behavior

The collection name is no longer correctly aligned since the improved collection design. The attached screenshot shows both the old and the new design with some colored lines to show the issue.

regression

It's not a big issue but it's a bit eyecatching for me that there is something wrong. :)

/cc @mcarare

Device information

  • Android device: OnePlus 7T Pro McLaren Edition, OxygenOS 10.0.7 (Android 10)
  • Fenix version: master branch revision 394f386

┆Issue is synchronized with this Jira Task

@cadeyrn cadeyrn added the 🐞 bug Crashes, Something isn't working, .. label Mar 29, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 29, 2020
@LittleAngelwings
Copy link

Here is one more screenshot from my homescreen. The collection name will be only half to see.

Screenshot_20200329-175048_Firefox Nightly

@ekager
Copy link
Contributor

ekager commented Mar 29, 2020

Regression from #9129
cc @mcarare if you want to follow up on this?

@mcarare mcarare self-assigned this Mar 30, 2020
@sv-sdeiac
Copy link

Hi, I also confirm that the issue from the description is reproducible using the latest version of Firefox Preview Nightly 3/29 #20891805.

Devices:

  • Google Pixel (Android 10);
  • Samsung Galaxy Tab S6 (Android 9);
  • LG g7 fit (Android 8.1).

Also, I wasn't able to reproduce the issue displayed by @LittleAngelwings. I tried using a big resolution or editing the size text from the app to ensure that is not related. Additionally, I tried also with different languages and still can't reproduce it.

mcarare added a commit to mcarare/fenix that referenced this issue Mar 30, 2020
@mcarare mcarare linked a pull request Mar 30, 2020 that will close this issue
4 tasks
mcarare added a commit to mcarare/fenix that referenced this issue Mar 30, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Mar 30, 2020
@ekager ekager added the eng:qa:needed QA Needed label Mar 30, 2020
@ekager
Copy link
Contributor

ekager commented Mar 30, 2020

Opening for verification

@ekager ekager reopened this Mar 30, 2020
@abodea abodea added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist and removed needs:triage Issue needs triage labels Mar 30, 2020
@LittleAngelwings
Copy link

My reported issues is only on my Samsung Galaxy Tab A6 SM-T580 with Android 8.1.0.
On my Huawei Smartphone P Smart (2017) I haven't this problem,

@LittleAngelwings
Copy link

Collection name is complete shown for me with the latest build via GP

Nightly 200330 18:00 (Build #20901803)
38.0.20200329190103, 1341d92fa
GV: 76.0a1-20200327094805
AS: 0.55.0

@sflorean
Copy link
Contributor

Verified as fixed on Nightly build 200331.
Devices: Samsung Galaxy Note10 (Android 10), Nokia 6 (Android 7.1.1), Xiaomi Mi Pad 2 (Android 5.1).

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 31, 2020
@liuche liuche mentioned this issue Apr 13, 2020
32 tasks
@liuche liuche mentioned this issue Apr 28, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Collections S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants