Sort logins #9505

vesta0 · 2020-03-30T05:54:08Z

User Story

As a user, I want to be able to sort my logins, so I can find what I am looking for faster.

UX Mocks

Acceptance Criteria

I can sort my logins alphabetically
I can sort my logins by last used

┆Issue is synchronized with this Jira Task

ValentinTimisica · 2020-03-31T12:17:26Z

I started to work on this and making good progress but I saw in the provided UI specs that:

there is no indication for the user that "Saved logins" can be pressed to start an action
there is no indication to the user what is the current sorting strategy (once you pressed "Last used", for example, the list will be sorted but the options will disappear and the user will no longer be able to see "Last used" anywhere)

I propose keeping "Saved logins" as the title of the screen, shown in the top toolbar and then

have a Spinner
(similar to this https://developer.android.com/images/ui/spinner.png
"Items sorted" [alphabetically, last used]),
element familiar to users as indicator of the current sorting strategy and which would also allow easily choosing a different sorting strategy as the first static element
the list of items below the spinner

What do you think @AmyYLee?

AmyYLee · 2020-03-31T16:00:57Z

@ValentinTimisica Hi, thanks for pointing that out. I had a drop-down arrow in my original mock. I updated some assets and somehow the arrow was lost. I've updated the mocks with the drop-down arrow. The selected sort order is highlighted in grey when the user opens the menu.

ValentinTimisica · 2020-04-06T15:17:01Z

@AmyYLee, can you also give me links(from abstract) with the UX mocks for dark theme and private mode?

AmyYLee · 2020-04-14T16:46:18Z

@AmyYLee, can you also give me links(from abstract) with the UX mocks for dark theme and private mode?
@ValentinTimisica Hi, I've added screens to the original mock. Let me know if you have any questions. It mostly follows what we currently have for Dark/Private theme.

https://share.goabstract.com/33afd8de-f90e-4504-90e3-ee2a3bcb1925?mode=design&sha=5b9a5b4a7dfe6bfd32504d101af0c0b54ee216e9

ValentinTimisica · 2020-04-15T08:03:19Z

@AmyYLee, I saw that you added private mode and dark theme mocks for "Edit logins" but I need the mocks for "Sort by" part.

AmyYLee · 2020-04-15T16:17:55Z

@ValentinTimisica

Hi, the drop-down follows the same styling as all of our menus in app. Please see below. Let me know if you have any questions. Please use below as reference for colours for dark/private theme

Currently we support sorting by name and by last used. Also, the selected option is saved in shared preferences so that the last option chosen by the user is properly displayed even after the app was restarted.

AndiAJ · 2020-05-11T09:11:51Z

Hi, verified as fixed on the latest Nightly Build 200511 from 5/11 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

AndiAJ · 2020-05-20T08:00:43Z

Hi, I've re-checked this matter on Beta 5.1.0-beta.1 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

It seems that the login credentials aren't properly sorted by default (sorted random)

1st scenario Name (A-Z)

Prerequisite:

Leave the sorting option set to Name (A-Z) (Sort alphabetically)

Steps to reproduce:

Log in to the following websites in this order:
• Twitter
• Facebook
• Yahoo
• Instagram
Check the saved logins

Expected behavior

The login credentials should be sorted as it follows:
• Facebook
• Instagram
• Yahoo
• Twitter

Actual behavior

• Yahoo
• Facebook
• Twitter
• Instagram

Notes

❗ Reproducible on the latest Nightly 200520 from 5/20
❗ If you select again the Name (A-Z) option the credentials will be properly sorted.
On the other hand, if you close and re-open Fenix the credentials will be again sorted randomly
(as per the Actual behaviour)

2nd Scenario Last used

Prerequisite:

Clean profile no Login credentials saved.
Set the sorting option to Last used

Steps to reproduce:

Log in to the following websites in this order:
• Twitter
• Facebook
• Yahoo
• Instagram
Check the saved logins

Expected behavior

The login credentials should be sorted as it follows:
• Instagram
• Yahoo
• Facebook
• Twitter

Actual behavior

• Yahoo
• Facebook
• Twitter
• Instagram

Notes

❗ Reproducible on the latest Nightly 200520 from 5/20
❗ If you select again the Last used option the credentials will be properly sorted.
On the other hand, if you close and re-open Fenix the credentials will be again sorted randomly
(as per the Actual behaviour)

@eliserichards & @ValentinTimisica - Please review and share your thoughts
I'll re-open this issue.

ValentinTimisica · 2020-05-21T09:39:41Z

Thanks @AndiAJ. Seems like it's a regression from #9693. I'll try to fix it.

Opened #10815 based on your comment.
Closing this for now.

vesta0 added eng:ready Ready for engineering Feature:Logins labels Mar 30, 2020

vesta0 added this to Privacy in Fenix Q2 Feature Backlog Mar 30, 2020

github-actions bot added the needs:triage Issue needs triage label Mar 30, 2020

vesta0 mentioned this issue Mar 30, 2020

[Meta] Bring additional Lockwise Features to the browser #5774

Closed

4 tasks

ValentinTimisica self-assigned this Mar 30, 2020

vesta0 removed the needs:triage Issue needs triage label Mar 30, 2020

vesta0 assigned AmyYLee Mar 30, 2020

vesta0 added this to Prioritized Feature Backlog in Fenix Sprint Kanban Mar 31, 2020

eliserichards self-assigned this Mar 31, 2020

ValentinTimisica mentioned this issue Apr 7, 2020

Allow simple highlightable menu items mozilla-mobile/android-components#6558

Closed

ValentinTimisica added the needs:UX-feedback Needs UX Feedback label Apr 9, 2020

AmyYLee removed the needs:UX-feedback Needs UX Feedback label Apr 14, 2020

ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Apr 16, 2020

For mozilla-mobile#9505: Adds tests for sort saved logins

2f01977

This was referenced Apr 18, 2020

Add the possibility to filter the saved logins Alphabetically or after Recently used #9326

Closed

Implement a way to sort the Saved Logins/Accounts Alphabetically or by Recently used #6719

Closed

liuche moved this from Prioritized Feature Backlog to In Progress in Fenix Sprint Kanban Apr 22, 2020

ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Apr 30, 2020

For mozilla-mobile#9505: Adds tests for sort saved logins

277c06e

ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 4, 2020

For mozilla-mobile#9505: Adds tests for sort saved logins

38c1440

ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 5, 2020

For mozilla-mobile#9505: Adds tests for sort saved logins

8e20d67

ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 6, 2020

For mozilla-mobile#9505: Adds tests for sort saved logins

8d0f771

AmyYLee linked a pull request May 6, 2020 that will close this issue

Fixes #9504: Edit logins #9693

Merged

10 tasks

AmyYLee removed a link to a pull request May 6, 2020

Fixes #9504: Edit logins #9693

Merged

10 tasks

ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 7, 2020

For mozilla-mobile#9505: Adds tests for sort saved logins

7689fda

ekager pushed a commit that referenced this issue May 7, 2020

For #9505: Adds tests for sort saved logins

77705d1

eliserichards moved this from In Progress to In Dev Review in Fenix Sprint Kanban May 7, 2020

eliserichards added the eng:qa:needed QA Needed label May 7, 2020

project-bot bot moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban May 7, 2020

liuche moved this from Ready for QA to In Dev Review in Fenix Sprint Kanban May 7, 2020

liuche moved this from In Dev Review to Ready for QA in Fenix Sprint Kanban May 7, 2020

AndiAJ closed this as completed May 11, 2020

AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 11, 2020

project-bot bot moved this from Ready for QA to Sprint Backlog in Fenix Sprint Kanban May 11, 2020

ValentinTimisica moved this from Sprint Backlog to Sprint 20.8 Done in Fenix Sprint Kanban May 11, 2020

vesta0 added this to Q2: Fenix in Fenix Product Backlog May 12, 2020

liuche mentioned this issue May 19, 2020

Releng 5.1 #10774

Closed

32 tasks

AndiAJ reopened this May 20, 2020

sflorean mentioned this issue May 20, 2020

[Bug]Saved logins view scrolling issue after sorting #10777

Closed

ValentinTimisica mentioned this issue May 21, 2020

[Bug] Login credentials not sorted by default #10815

Closed

ValentinTimisica closed this as completed May 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sort logins #9505

Sort logins #9505

vesta0 commented Mar 30, 2020 •

edited by data-sync-user

Loading

ValentinTimisica commented Mar 31, 2020

AmyYLee commented Mar 31, 2020

ValentinTimisica commented Apr 6, 2020

AmyYLee commented Apr 14, 2020

ValentinTimisica commented Apr 15, 2020

AmyYLee commented Apr 15, 2020 •

edited

Loading

AndiAJ commented May 11, 2020

AndiAJ commented May 20, 2020

ValentinTimisica commented May 21, 2020

Sort logins #9505

Sort logins #9505

Comments

vesta0 commented Mar 30, 2020 • edited by data-sync-user Loading

User Story

Acceptance Criteria

ValentinTimisica commented Mar 31, 2020

AmyYLee commented Mar 31, 2020

ValentinTimisica commented Apr 6, 2020

AmyYLee commented Apr 14, 2020

ValentinTimisica commented Apr 15, 2020

AmyYLee commented Apr 15, 2020 • edited Loading

AndiAJ commented May 11, 2020

AndiAJ commented May 20, 2020

1st scenario Name (A-Z)

Prerequisite:

Steps to reproduce:

Expected behavior

Actual behavior

Notes

2nd Scenario Last used

Prerequisite:

Steps to reproduce:

Expected behavior

Actual behavior

Notes

ValentinTimisica commented May 21, 2020

vesta0 commented Mar 30, 2020 •

edited by data-sync-user

Loading

AmyYLee commented Apr 15, 2020 •

edited

Loading