Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Sort logins #9505

Closed
2 tasks done
vesta0 opened this issue Mar 30, 2020 · 9 comments
Closed
2 tasks done

Sort logins #9505

vesta0 opened this issue Mar 30, 2020 · 9 comments
Assignees
@AmyYLee @eliserichards @ValentinTimisica
Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Logins

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Mar 30, 2020 •
edited by data-sync-user
Loading

User Story

As a user, I want to be able to sort my logins, so I can find what I am looking for faster.

UX Mocks

Acceptance Criteria

  • I can sort my logins alphabetically
  • I can sort my logins by last used

┆Issue is synchronized with this Jira Task
@vesta0 vesta0 added eng:ready Ready for engineering Feature:Logins labels Mar 30, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 30, 2020
@vesta0 vesta0 mentioned this issue Mar 30, 2020
Closed
4 tasks
@ValentinTimisica ValentinTimisica self-assigned this Mar 30, 2020
@vesta0 vesta0 removed the needs:triage Issue needs triage label Mar 30, 2020
@ValentinTimisica
Copy link
Contributor

I started to work on this and making good progress but I saw in the provided UI specs that:

  • there is no indication for the user that "Saved logins" can be pressed to start an action
    Screen Shot 2020-03-31 at 3 10 13 PM

  • there is no indication to the user what is the current sorting strategy (once you pressed "Last used", for example, the list will be sorted but the options will disappear and the user will no longer be able to see "Last used" anywhere)
    Screen Shot 2020-03-31 at 3 10 29 PM

I propose keeping "Saved logins" as the title of the screen, shown in the top toolbar and then

  • have a Spinner
    (similar to this https://developer.android.com/images/ui/spinner.png
    "Items sorted" [alphabetically, last used]),
    element familiar to users as indicator of the current sorting strategy and which would also allow easily choosing a different sorting strategy as the first static element
  • the list of items below the spinner

What do you think @AmyYLee?

@AmyYLee
Copy link
Collaborator

AmyYLee commented Mar 31, 2020

@ValentinTimisica Hi, thanks for pointing that out. I had a drop-down arrow in my original mock. I updated some assets and somehow the arrow was lost. I've updated the mocks with the drop-down arrow. The selected sort order is highlighted in grey when the user opens the menu.
Screen Shot 2020-03-31 at 11 58 44

@eliserichards eliserichards self-assigned this Mar 31, 2020
@ValentinTimisica
Copy link
Contributor

@AmyYLee, can you also give me links(from abstract) with the UX mocks for dark theme and private mode?

@ValentinTimisica ValentinTimisica mentioned this issue Apr 7, 2020
Closed
@ValentinTimisica ValentinTimisica added the needs:UX-feedback Needs UX Feedback label Apr 9, 2020
@AmyYLee
Copy link
Collaborator

AmyYLee commented Apr 14, 2020

@AmyYLee, can you also give me links(from abstract) with the UX mocks for dark theme and private mode?
@ValentinTimisica Hi, I've added screens to the original mock. Let me know if you have any questions. It mostly follows what we currently have for Dark/Private theme.

https://share.goabstract.com/33afd8de-f90e-4504-90e3-ee2a3bcb1925?mode=design&sha=5b9a5b4a7dfe6bfd32504d101af0c0b54ee216e9

@AmyYLee AmyYLee removed the needs:UX-feedback Needs UX Feedback label Apr 14, 2020
@ValentinTimisica
Copy link
Contributor

@AmyYLee, I saw that you added private mode and dark theme mocks for "Edit logins" but I need the mocks for "Sort by" part.

Saved_logins_light_theme_mock

@AmyYLee
Copy link
Collaborator

AmyYLee commented Apr 15, 2020 •
edited
Loading

@ValentinTimisica

Hi, the drop-down follows the same styling as all of our menus in app. Please see below. Let me know if you have any questions. Please use below as reference for colours for dark/private theme

Screenshot_20200415-121416
Screenshot_20200415-121424

ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Apr 16, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds possibility to sort saved logins
033297b 
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Apr 16, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds tests for sort saved logins
2f01977
This was referenced Apr 18, 2020
Closed
Closed
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Apr 30, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds possibility to sort saved logins
6c5f14c 
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue Apr 30, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds tests for sort saved logins
277c06e
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 4, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds possibility to sort saved logins
81a7830 
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 4, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds tests for sort saved logins
38c1440
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 5, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds possibility to sort saved logins
cde9aa5 
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 5, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds tests for sort saved logins
8e20d67
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 6, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds possibility to sort saved logins
2ce81eb 
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 6, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds tests for sort saved logins
8d0f771
@AmyYLee AmyYLee linked a pull request May 6, 2020 that will close this issue
Fixes #9504: Edit logins #9693
Merged
10 tasks
@AmyYLee AmyYLee removed a link to a pull request May 6, 2020
Fixes #9504: Edit logins #9693
Merged
10 tasks
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 7, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds possibility to sort saved logins
35042c7 
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
ValentinTimisica added a commit to ValentinTimisica/fenix that referenced this issue May 7, 2020
@ValentinTimisica
For mozilla-mobile#9505: Adds tests for sort saved logins
7689fda
ekager pushed a commit that referenced this issue May 7, 2020
@ValentinTimisica @ekager
For #9505: Adds possibility to sort saved logins
24ba9f2 
Currently we support sorting by name and by last used. Also, the selected
option is saved in shared preferences so that the last option chosen by
the user is properly displayed even after the app was restarted.
ekager pushed a commit that referenced this issue May 7, 2020
@ValentinTimisica @ekager
For #9505: Adds tests for sort saved logins
77705d1
@eliserichards eliserichards added the eng:qa:needed QA Needed label May 7, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented May 11, 2020

Hi, verified as fixed on the latest Nightly Build 200511 from 5/11 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

@AndiAJ AndiAJ closed this as completed May 11, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 11, 2020
@liuche liuche mentioned this issue May 19, 2020
Closed
32 tasks
@AndiAJ
Copy link
Collaborator

AndiAJ commented May 20, 2020

Hi, I've re-checked this matter on Beta 5.1.0-beta.1 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

It seems that the login credentials aren't properly sorted by default (sorted random)

1st scenario Name (A-Z)

Prerequisite:

Leave the sorting option set to Name (A-Z) (Sort alphabetically)

Steps to reproduce:

  1. Log in to the following websites in this order:
    • Twitter
    • Facebook
    • Yahoo
    • Instagram
  2. Check the saved logins

Expected behavior

The login credentials should be sorted as it follows:
• Facebook
• Instagram
• Yahoo
• Twitter

Actual behavior

• Yahoo
• Facebook
• Twitter
• Instagram

Notes

❗ Reproducible on the latest Nightly 200520 from 5/20
❗ If you select again the Name (A-Z) option the credentials will be properly sorted.
On the other hand, if you close and re-open Fenix the credentials will be again sorted randomly
(as per the Actual behaviour)

2nd Scenario Last used

Prerequisite:

Clean profile no Login credentials saved.
Set the sorting option to Last used

Steps to reproduce:

  1. Log in to the following websites in this order:
    • Twitter
    • Facebook
    • Yahoo
    • Instagram
  2. Check the saved logins

Expected behavior

The login credentials should be sorted as it follows:
• Instagram
• Yahoo
• Facebook
• Twitter

Actual behavior

• Yahoo
• Facebook
• Twitter
• Instagram

Notes

❗ Reproducible on the latest Nightly 200520 from 5/20
❗ If you select again the Last used option the credentials will be properly sorted.
On the other hand, if you close and re-open Fenix the credentials will be again sorted randomly
(as per the Actual behaviour)

@eliserichards & @ValentinTimisica - Please review and share your thoughts
I'll re-open this issue.

@AndiAJ AndiAJ reopened this May 20, 2020
@sflorean sflorean mentioned this issue May 20, 2020
Closed
@ValentinTimisica ValentinTimisica mentioned this issue May 21, 2020
Closed
@ValentinTimisica
Copy link
Contributor

Thanks @AndiAJ. Seems like it's a regression from #9693. I'll try to fix it.

Opened #10815 based on your comment.
Closing this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AmyYLee AmyYLee

@eliserichards eliserichards

@ValentinTimisica ValentinTimisica

Labels
eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Logins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@AmyYLee @vesta0 @eliserichards @AndiAJ @ValentinTimisica