-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Telemetry for Custom tabs #977
Comments
@bbinto, @vesta0 are we sure that the linked telemetry events are correct? @pocmo brings up a good point--a custom tab is not part of the normal tab view, thus it doesn't matter which one is 'selected' or which tab # it is, right? |
The events listed for Focus are
@sblatz - all I want to do here is to know/track when a user opens a link (from a different app) in Fenix by using the apps custom tabs implementation. The app, e.g LinkedIn can decide how to present the Chrome of Fenix. For Focus we were able to also keep track of these events, The probe will help us to understand how many people come in from other apps via custom tabs and/or the regular intents. Here two screenshots, one from the LinkedIn app (custom tab) vs. opened the link via the SMS app (not custom tab, opens link in default browser = Fenix) So I'd like to track
Please ping me @sblatz if you want to chat. I hope that helped. This is how it looks in Focus + LinkedIn article link |
I'm updating the sizing of this as it actually required me to implement "fact emitting" on the a-c side and observe those in Fenix. |
Hello, I'm still reproducing this issue for:
Please note the following:
I will remove the QA Needed based on my comment until the issue will be fixed. |
Did a bit of investigation. It looks like the custom tab facts are not firing properly from android components. This means that these pairings never happen and our telemetry won't send. |
@abodea what app were you using to test the "action button"? Was it a share button or something else? |
I've opened a PR in a-c that will handle the share case: mozilla-mobile/android-components#3249 |
I synced up with @abodea who mentioned these steps:
Based on this, the a-c PR I opened should fix the problem! |
Verified as fixed on the latest build from CUSTOM_TAB### And here is the CUSTOM_TAB: { "events": [ { "timestamp": 0, "category": "events", "name": "app_opened", "extra": { "source": "CUSTOM_TAB" } }, { "timestamp": 911, "category": "custom_tab", "name": "menu" }, { "timestamp": 16884, "category": "custom_tab", "name": "closed" }Action_Button### And here is the Action Button: { "events": [ { "timestamp": 0, "category": "events", "name": "app_opened", "extra": { "source": "CUSTOM_TAB" } }, { "timestamp": 46128, "category": "custom_tab", "name": "action_button" } ], |
Similar to Custom Tabs events in Focus: https://github.com/mozilla-mobile/focus-android/blob/master/docs/Telemetry.md#custom-tabs
As a product owner, I want to track the usage of "find in page" in Fenix so that I can understand how our users leverage the feature, and detect anomalies or issues in user flow and usage.
Hypothesis
We believe this feature is useful to users, and successful when
What questions will you answer with this data?
Probes
Dependencies (Added by PM and Eng)
Acceptance Criteria (Added by PM)
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: