Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] PWAs leave space with dynamic bottom toolbar #9892

Closed
sblatz opened this issue Apr 13, 2020 · 4 comments
Closed

[Bug] PWAs leave space with dynamic bottom toolbar #9892

sblatz opened this issue Apr 13, 2020 · 4 comments
Assignees
@sblatz
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search

Comments

@sblatz
Copy link
Contributor

sblatz commented Apr 13, 2020 •
edited by data-sync-user

Example:

Originally from #8768

┆Issue is synchronized with this Jira Task
@sblatz sblatz added 🐞 bug Crashes, Something isn't working, .. Feature:Toolbar Address bar, see also Feature:Search labels Apr 13, 2020
@sblatz sblatz self-assigned this Apr 13, 2020
@sblatz sblatz mentioned this issue Apr 13, 2020
Closed
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 13, 2020
@sblatz sblatz changed the title [Bug] PWA's leave space with dynamic bottom toolbar [Bug] PWAs leave space with dynamic bottom toolbar Apr 13, 2020
@sblatz sblatz removed the needs:triage Issue needs triage label Apr 13, 2020
@snorp
Copy link

snorp commented Apr 13, 2020

For PWAs we need to set the max toolbar height to 0, since we're never going to show it.

@sblatz
Copy link
Contributor Author

sblatz commented Apr 13, 2020

@snorp Yep! Have a patch almost ready to go 😄

sblatz added a commit to sblatz/fenix that referenced this issue Apr 13, 2020
@sblatz
For mozilla-mobile#9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs
4826376
@sblatz
Copy link
Contributor Author

sblatz commented Apr 13, 2020

#9893

sblatz added a commit that referenced this issue Apr 13, 2020
@sblatz
For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (#9893)
7c3394e
@sblatz sblatz added the eng:qa:needed QA Needed label Apr 13, 2020
@liuche liuche mentioned this issue Apr 13, 2020
Closed
32 tasks
liuche pushed a commit that referenced this issue Apr 13, 2020
@sblatz @liuche
For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs (#9893)
2303c58
@Diana-Rus
Copy link

Diana-Rus commented Apr 14, 2020 •
edited

Hi, verified the issue with Google Pixel 3 XL (Android 9), Sony Xperia Z5 (Android 7) and Samsung Galaxy S9 (Android 8) on a recent nightly debug build 39.0.20200413130047, d433836f0 GV: 77.0a1-20200410095419.

Note:

  • The PWA option is not yet present in Beta 4.3.0-beta.1
  • Verified with Twitter and Instagram set as PWA.

Google Pixel 3 XL (Android 9) - Twitter - Nightly debug build - GIF
20200414-124156

Samsung Galaxy S9 (Android 8) - Instagram - Nightly debug build - GIF
20200414-151417

@Diana-Rus Diana-Rus added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 14, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Toolbar Address bar, see also Feature:Search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snorp @sblatz @Diana-Rus