Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs #9893

Merged
merged 1 commit into from Apr 13, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Apr 13, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Copy link

@snorp snorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sblatz sblatz changed the title For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs RUN Apr 13, 2020
@sblatz sblatz changed the title For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs RUN For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs Apr 13, 2020
@codecov-io
Copy link

codecov-io commented Apr 13, 2020

Codecov Report

Merging #9893 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9893      +/-   ##
============================================
- Coverage     19.16%   19.16%   -0.01%     
  Complexity      521      521              
============================================
  Files           337      337              
  Lines         13738    13739       +1     
  Branches       1839     1840       +1     
============================================
  Hits           2633     2633              
- Misses        10865    10866       +1     
  Partials        240      240              
Impacted Files Coverage Δ Complexity Δ
...lla/fenix/customtabs/ExternalAppBrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c23840...4826376. Read the comment docs.

@sblatz sblatz merged commit 7c3394e into mozilla-mobile:master Apr 13, 2020
@liuche liuche mentioned this pull request Apr 13, 2020
32 tasks
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants