Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Revert "Bug 1631839 - part 1: Expose new routes without project." #10139

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

JohanLorenzo
Copy link
Contributor

Reverts #10092

#10092 broke the decision task with an error I've never seen before and I currently don't understand:

[task 2020-04-23T09:26:18.316Z] 2020-04-23 09:26:18,316 - INFO - Replaced 7 tasks by index-search during optimization.
[task 2020-04-23T09:26:18.318Z] Traceback (most recent call last):
[task 2020-04-23T09:26:18.319Z]   File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/main.py", line 480, in main
[task 2020-04-23T09:26:18.319Z]     args.command(vars(args))
[task 2020-04-23T09:26:18.320Z]   File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/main.py", line 320, in decision
[task 2020-04-23T09:26:18.320Z]     taskgraph_decision(options)
[task 2020-04-23T09:26:18.320Z]   File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/decision.py", line 109, in taskgraph_decision
[task 2020-04-23T09:26:18.321Z]     write_artifact('task-graph.json', tgg.morphed_task_graph.to_json())
[task 2020-04-23T09:26:18.321Z]   File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/generator.py", line 199, in morphed_task_graph
[task 2020-04-23T09:26:18.321Z]     return self._run_until('morphed_task_graph')
[task 2020-04-23T09:26:18.321Z]   File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/generator.py", line 338, in _run_until
[task 2020-04-23T09:26:18.322Z]     k, v = self._run.next()
[task 2020-04-23T09:26:18.322Z]   File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/generator.py", line 330, in _run
[task 2020-04-23T09:26:18.322Z]     optimized_task_graph, label_to_taskid, parameters, graph_config)
[task 2020-04-23T09:26:18.322Z]   File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/morph.py", line 246, in morph
[task 2020-04-23T09:26:18.323Z]     taskgraph, label_to_taskid = m(taskgraph, label_to_taskid, parameters, graph_config)
[task 2020-04-23T09:26:18.323Z]   File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/morph.py", line 159, in add_index_tasks
[task 2020-04-23T09:26:18.324Z]     added.append(make_index_task(task, taskgraph, label_to_taskid, parameters, graph_config))
[task 2020-04-23T09:26:18.324Z]   File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/morph.py", line 122, in make_index_task
[task 2020-04-23T09:26:18.324Z]     taskgraph, label_to_taskid, parameters, graph_config)
[task 2020-04-23T09:26:18.325Z]   File "/builds/worker/.local/lib/python2.7/site-packages/taskgraph/morph.py", line 59, in derive_misc_task
[task 2020-04-23T09:26:18.325Z]     image_taskid = label_to_taskid['build-docker-image-' + image]
[task 2020-04-23T09:26:18.325Z] KeyError: u'build-docker-image-index-task'

@JohanLorenzo JohanLorenzo merged commit b703e1b into master Apr 23, 2020
@JohanLorenzo JohanLorenzo deleted the revert-10092-bug-1631839-1 branch April 23, 2020 09:59
@JohanLorenzo
Copy link
Contributor Author

JohanLorenzo commented Apr 23, 2020

Follow up: I know the root cause of this backout and it's documented at https://bugzilla.mozilla.org/show_bug.cgi?id=1632514

Amejia481 pushed a commit to Amejia481/fenix that referenced this pull request Apr 23, 2020
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants