Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #10321: Tab tray media state #10422

Merged
merged 4 commits into from May 20, 2020

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented May 5, 2020

Fixes #10321

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@darkwing darkwing force-pushed the tab-tray-media-state branch 6 times, most recently from d18625a to 323a00c Compare May 7, 2020 18:29
@codecov-io
Copy link

codecov-io commented May 7, 2020

Codecov Report

Merging #10422 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10422      +/-   ##
============================================
- Coverage     19.39%   19.31%   -0.08%     
  Complexity      602      602              
============================================
  Files           360      361       +1     
  Lines         14578    14637      +59     
  Branches       1951     1956       +5     
============================================
  Hits           2827     2827              
- Misses        11493    11552      +59     
  Partials        258      258              
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 8.87% <0.00%> (+0.05%) 10.00 <0.00> (ø)
...ava/org/mozilla/fenix/tabtray/TabTrayViewHolder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef5cf3...7f05d5d. Read the comment docs.

@gabrielluong gabrielluong linked an issue May 8, 2020 that may be closed by this pull request
@darkwing darkwing changed the title WIP: Tab tray media state For #10321: Tab tray media state May 13, 2020
@darkwing darkwing requested a review from boek May 13, 2020 16:14
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick question! Otherwise lgtm

app/src/main/res/drawable/pause_with_background.xml Outdated Show resolved Hide resolved
@darkwing darkwing requested a review from topotropic May 18, 2020 16:56
Copy link

@topotropic topotropic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added a comment for updating the colors: #10422 (comment) Thank you!

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #10422 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10422      +/-   ##
============================================
- Coverage     19.17%   19.09%   -0.08%     
  Complexity      600      600              
============================================
  Files           360      361       +1     
  Lines         14846    14905      +59     
  Branches       2015     2020       +5     
============================================
  Hits           2846     2846              
- Misses        11740    11799      +59     
  Partials        260      260              
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 8.72% <0.00%> (+0.05%) 10.00 <0.00> (ø)
...ava/org/mozilla/fenix/tabtray/TabTrayViewHolder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2795a34...750036e. Read the comment docs.

@darkwing
Copy link
Contributor Author

Colors updated!

MediaState

@boek boek requested review from topotropic and removed request for topotropic May 20, 2020 21:47
@boek boek dismissed topotropic’s stale review May 20, 2020 21:48

Nicole said everything looks good on Slack

@darkwing darkwing merged commit 346b4aa into mozilla-mobile:master May 20, 2020
@liuche liuche mentioned this pull request Jun 10, 2020
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab Tray - Implement Media Play State
5 participants