Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #10865 - Implement 3 dot menu for tab tray #10869

Merged
merged 6 commits into from May 27, 2020

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented May 22, 2020

Fixes #10865

To Do:

  • Wire up "close all tabs"
  • Wire up "save to collection"
  • Share - The data is being fetched correctly but the navigation to share fragment isn't happening.

@darkwing darkwing requested a review from boek May 22, 2020 21:21
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #10869 into master will decrease coverage by 0.32%.
The diff coverage is 12.40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10869      +/-   ##
============================================
- Coverage     19.61%   19.29%   -0.33%     
+ Complexity      631      628       -3     
============================================
  Files           363      363              
  Lines         14975    15132     +157     
  Branches       2024     2042      +18     
============================================
- Hits           2937     2919      -18     
- Misses        11761    11937     +176     
+ Partials        277      276       -1     
Impacted Files Coverage Δ Complexity Δ
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nix/components/toolbar/BrowserToolbarController.kt 66.48% <0.00%> (ø) 0.00 <0.00> (ø)
...lla/fenix/components/toolbar/DefaultToolbarMenu.kt 42.50% <0.00%> (-1.54%) 13.00 <0.00> (ø)
...g/mozilla/fenix/customtabs/CustomTabToolbarMenu.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/org/mozilla/fenix/settings/SettingsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../org/mozilla/fenix/settings/about/AboutFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...org/mozilla/fenix/tabtray/TabTrayDialogFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54cb8f0...884a821. Read the comment docs.

Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of small nits!

@darkwing darkwing changed the title WIP - For #10865 - Implement 3 dot menu for tab tray For #10865 - Implement 3 dot menu for tab tray May 27, 2020
@darkwing darkwing merged commit 2482372 into mozilla-mobile:master May 27, 2020
@liuche liuche mentioned this pull request Jun 10, 2020
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab Tray - Implement Three-Dot Menu
3 participants