This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #10865 - Implement 3 dot menu for tab tray #10869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10869 +/- ##
============================================
- Coverage 19.61% 19.29% -0.33%
+ Complexity 631 628 -3
============================================
Files 363 363
Lines 14975 15132 +157
Branches 2024 2042 +18
============================================
- Hits 2937 2919 -18
- Misses 11761 11937 +176
+ Partials 277 276 -1
Continue to review full report at Codecov.
|
boek
suggested changes
May 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of small nits!
app/src/main/java/org/mozilla/fenix/tabtray/TabTrayDialogFragment.kt
Outdated
Show resolved
Hide resolved
darkwing
changed the title
WIP - For #10865 - Implement 3 dot menu for tab tray
For #10865 - Implement 3 dot menu for tab tray
May 27, 2020
boek
approved these changes
May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10865
To Do: