For #11063: Update telemetry for etp settings #11383
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data-review+, code-review+
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, documented in metrics.md
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, Fenix telemetry
- If the request is for permanent data collection, is there someone who will monitor the data over time?
No, has expiry
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2, what Tracking Protection setting the user is selecting
-
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No, changing of a Fenix setting
- Is the data collection covered by the existing Firefox privacy notice?
Yes, user interaction
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
No, has expiry
- Does the data collection use a third-party collection tool? If yes, escalate to legal.
No
Codecov Report
@@ Coverage Diff @@
## master #11383 +/- ##
=========================================
Coverage 20.86% 20.87%
Complexity 678 678
=========================================
Files 372 372
Lines 14861 14863 +2
Branches 2000 2000
=========================================
+ Hits 3101 3102 +1
- Misses 11478 11479 +1
Partials 282 282
Continue to review full report at Codecov.
|
Pull Request checklist
After merge
To download an APK when reviewing a PR: