Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11063: Update telemetry for etp settings #11383

Merged
merged 1 commit into from Jun 11, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Jun 9, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz changed the title Work For #11063: Update telemetry for etp settings Jun 9, 2020
@sblatz
Copy link
Contributor Author

sblatz commented Jun 9, 2020

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often and what percentage of users change their ETP setting?
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • We want to know which ETP setting our users prefer so we can better optimize their default privacy settings.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • We currently properly track standard and strict, and just need to upgrade this to include "custom." The current behavior we have is sufficient for tracking the other two, which is why we're following that for custom!
  1. Can current instrumentation answer these questions?
  • No, see above.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • Until 09/01/2020
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@sblatz sblatz requested a review from liuche June 9, 2020 17:48
@sblatz sblatz added the needs:data-review PR is awaiting a data review label Jun 9, 2020
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data-review+, code-review+

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, documented in metrics.md

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, Fenix telemetry

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

No, has expiry

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2, what Tracking Protection setting the user is selecting

  1. Is the data collection request for default-on or default-off?
    Default on

  2. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No, changing of a Fenix setting

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes, user interaction

  1. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

No, has expiry

  1. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No

@liuche liuche closed this Jun 10, 2020
@liuche liuche reopened this Jun 10, 2020
@liuche liuche removed the needs:data-review PR is awaiting a data review label Jun 10, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #11383 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #11383   +/-   ##
=========================================
  Coverage     20.86%   20.87%           
  Complexity      678      678           
=========================================
  Files           372      372           
  Lines         14861    14863    +2     
  Branches       2000     2000           
=========================================
+ Hits           3101     3102    +1     
- Misses        11478    11479    +1     
  Partials        282      282           
Impacted Files Coverage Δ Complexity Δ
...va/org/mozilla/fenix/components/metrics/Metrics.kt 20.05% <ø> (ø) 0.00 <0.00> (ø)
...zilla/fenix/settings/TrackingProtectionFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
app/src/main/java/org/mozilla/fenix/Config.kt 33.33% <0.00%> (ø) 2.00% <0.00%> (ø%)
...ug/java/org/mozilla/fenix/DebugFenixApplication.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...g/mozilla/fenix/crashes/CrashReporterController.kt 95.45% <0.00%> (+0.21%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31edbc9...1f3d9cc. Read the comment docs.

@ekager ekager merged commit 932a2f3 into mozilla-mobile:master Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants