Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #20516: Renew product telemetry probes expiring in August #20517

Merged

Conversation

eliserichards
Copy link
Contributor

@eliserichards eliserichards commented Jul 26, 2021

For #20516
Doc [waiting for approval from Vesta]: https://docs.google.com/document/d/1NGlnTa9TPyTnd3ciUPbwujbITjkX8p8vJybXcZrrM2w/edit#

This does not include perf telemetry probes. The performance team will handle those updates.

Probes to delete

Probes to let expire

These will be evaluated later to determine if they can be deleted. Commit.

  • banner_open_in_app: displayed, dismissed, go_to_settings
  • user_specified_search_engines: custom_engine_added, custom_engine_deleted
  • search_suggestions: enable_in_private
  • private_browsing_shortcut: create_shortcut, cfr_add_shortcut, cfr_cancel, pinned_shortcut_priv, static_shortcut_tab, static_shortcut_priv
  • private_browsing_mode: Snackbar_undo , Notification_tapped
  • tip: displayed, pressed, closed
  • preferences: open_links_in_private, private_search_suggestions
  • find_in_page: opened, closed, searched_page
  • Total_uri_count

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards requested review from a team as code owners July 26, 2021 17:16
@eliserichards eliserichards added needs:product 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Jul 26, 2021
@eliserichards eliserichards linked an issue Jul 26, 2021 that may be closed by this pull request
@eliserichards
Copy link
Contributor Author

eliserichards commented Jul 26, 2021

Request for Data Collection Renewal

onboarding:
fxa_auto_signin:
fxa_manual_signin
privacy_notice
pref_toggled_private_browsing
pref_toggled_toolbar_position
pref_toggled_tracking_prot
pref_toggled_theme_picker
finish

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We will be optimizing and experimenting with onboarding in H2.

search_shortcuts:
selected

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Important for revenue tracking and optimization.

Toolbar_settings:
changed_position:

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    The data didn’t initially tell us what we wanted (there were bugs), so we want to continue tracking this so we can answer our questions.

login_dialog:
displayed:
cancelled
saved
never_save

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Still need to optimize this feature and we want trends from 6+mo of data.

Metrics
Default_browser:

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Metrics
Top_sites_count
has_top_sites

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Metrics
Recently_used_pwa_count
has_recent_pwas

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Metrics
search_count

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Metrics
Mozilla_products
default_moz_browser

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Metrics
toolbar_position

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Metrics
Close_tab_setting
tab_view_setting

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Metrics
search_widget_installed

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Metrics
Has_open_tabs
tabs_open_count

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Metrics
mobile_bookmarks_count
has_mobile_bookmarks
desktop_bookmarks_count
has_desktop_bookmarks

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Adjust_campaign

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We will be actively using Adjust in H2.

Adjust_ad_group, Adjust_creative, adjust_network

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire? 08/01/2022

  3. Why was the initial period of collection insufficient?
    We will be actively using Adjust in H2.

preferences:
search_suggestions_enabled
remote_debugging_enabled
telemetry_enabled
enhanced_tracking_protection
bookmarks_suggestion
browsing_history_suggestion
clipboard_suggestions_enabled
search_shortcuts_enabled
signed_in_sync
sync_items
voice_search_enabled
toolbar_position_setting
accessibility_services

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    These will be used when we launch MR2 to make the success dashboard.

preferences:
Open_links_in_app_enabled
user_theme

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    These will be used when we launch MR2 to make the success dashboard.

search.default_engine:
code
name
submission_url

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Important for revenue tracking and optimization.

sync_auth:
opened:
closed
use_email
use_email_problem
sign_in
sign_out
sign_up
paired
recovered
other_external
scan_pairing

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Important for overall strategy as it relates to the Firefox ecosystem.

sync_account:
opened
sync_now
send_tab
sign_in_to_send_tab

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Important for overall strategy as it relates to the Firefox ecosystem.

history:
opened
removed
Removed_all
shared

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We will be actively working on this in MR2.

tip:
displayed
pressed
closed

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?

reader_mode:
available
opened
closed
appearance

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    This feature will be important for the next major releases (following MR2)

Tabs_tray:
opened
closed
opened_existing_tab
closed_existing_tab
private_mode_tapped
normal_mode_tapped
synced_mode_tapped
new_tab_tapped
new_private_tab_tapped
menu_opened
save_to_collection
share_all_tabs
close_all_tabs

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We are making changes to the tabs tray during H2 2021.

search_widget:
new_tab_button:
voice_button

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Will be investigating the use of widgets in the future and will need this data to make informed decisions. This is also important for revenue tracking and optimization.

tracking_protection:
exception_added
panel_settings
etp_shield
etp_tracker_list
etp_settings
etp_setting_changed

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We are making changes to the tracking protection panel and settings during H2 2021. This will be part of our success metrics dashboard.

tab:
media_play:
media_pause

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We are continuing to make changes to how and where we are giving the users the ability to play/pause their media, so this data will give us a baseline against which we can compare those interactions.

media_notification:
play
pause

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We are continuing to make changes to how and where we are giving the users the ability to play/pause their media, so this data will give us a baseline against which we can compare those interactions.

media_state:
play:
pause
stop
fullscreen
picture_in_picture

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We are continuing to make changes to how and where we are giving the users the ability to interact with their media (e.g. play and pause), so this data will give us a baseline against which we can compare those interactions.

logins:
open_logins:
open_individual_login
copy_login
view_password_login
save_logins_setting_changed
open_login_editor
delete_saved_login
save_edited_login

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Still need to optimize this feature and we want trends from 6+mo of data.

voice_search.tapped:

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    This feature will be important for future initiatives and we will need historical data from 6+mo.

top_sites:
open_default:
open_frecency
open_pinned
swipe_carousel
long_press
open_in_new_tab
open_in_private_tab
remove

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We are making changes to the home screen in H2 2021 and want interaction data for top sites.

top_sites:
Open_google_search_attribution

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We are making changes to the home screen in H2 2021 and want interaction data for partner top sites.

pocket:
pocket_top_site_clicked:
pocket_top_site_removed

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We are making changes to the home screen in H2 2021 and want interaction data for top sites.

first_session: campaign, network, adgroup, creative, timestamp

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    Product continues to monitor first session use.

autoplay:
visited_setting:
setting_changed

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    We are continuing to make changes to how and where we are giving the users the ability to interact with their media (e.g. play and pause), so this data will give us a baseline against which we can compare those interactions.

tabs.setting_opened:

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    This will help us determine how (if) this is being used.

synced_tabs:
synced_tabs_suggestion_clicked

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    This data is important so we can explore feature optimization for synced tabs.

awesomebar:
bookmark_suggestion_clicked:
clipboard_suggestion_clicked
history_suggestion_clicked
search_action_clicked
search_suggestion_clicked
Opened_tab_suggestion_clicked

  1. Provide a link to the initial Data Collection Review Request for this collection.
  1. When will this collection now expire? 08/01/2022
  2. Why was the initial period of collection insufficient?
    This data is important so we can explore feature optimization for the awesomebar

@eliserichards eliserichards added the needs:data-review PR is awaiting a data review label Jul 26, 2021
@eliserichards eliserichards removed needs:product 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Jul 28, 2021
@eliserichards eliserichards added the needs:review PRs that need to be reviewed label Jul 28, 2021
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is for Data-Review+ only

onboarding:
fxa_auto_signin:
fxa_manual_signin
privacy_notice
pref_toggled_private_browsing
pref_toggled_toolbar_position
pref_toggled_tracking_prot
pref_toggled_theme_picker
finish

1. Provide a link to the initial Data Collection Review Request for this collection.


* [#10824: Onboarding telemetry #11867](https://github.com/mozilla-mobile/fenix/pull/11867)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We will be optimizing and experimenting with onboarding in H2.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

search_shortcuts:
selected

1. Provide a link to the initial Data Collection Review Request for this collection.


* [Closes #1194: Adds search shortcut telemetry #1202 (comment)](https://github.com/mozilla-mobile/fenix/pull/1202#issuecomment-476870449)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Important for revenue tracking and optimization.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Toolbar_settings:
changed_position:

1. Provide a link to the initial Data Collection Review Request for this collection.


* [ For #5694 & #6054: Allows users to change toolbar position #6608](https://github.com/mozilla-mobile/fenix/pull/6608)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   The data didn’t initially tell us what we wanted (there were bugs), so we want to continue tracking this so we can answer our questions.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

login_dialog:
displayed:
cancelled
saved
never_save

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #9730: Add Login Dialog Prompt telemetry #13050](https://github.com/mozilla-mobile/fenix/pull/13050)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Still need to optimize this feature and we want trends from 6+mo of data.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Metrics
Default_browser:

1. Provide a link to the initial Data Collection Review Request for this collection.


* [Backfill metrics pt. 1 #1067 (comment)](https://github.com/mozilla-mobile/fenix/pull/1067#issuecomment-474598673)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Metrics
Top_sites_count
has_top_sites

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #8125 - Send top sites count with metrics ping #9556](https://github.com/mozilla-mobile/fenix/pull/9556)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Metrics
Recently_used_pwa_count
has_recent_pwas

1. Provide a link to the initial Data Collection Review Request for this collection.


* [Closes #11909: Metrics for recording number of recently used PWAs #11982 (review)](https://github.com/mozilla-mobile/fenix/pull/11982#pullrequestreview-437963817)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Metrics
search_count

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #1158 - Add search counts #1677](https://github.com/mozilla-mobile/fenix/pull/1677)

* [For #5214 - Bumps expiration dates for telemetry #5216](https://github.com/mozilla-mobile/fenix/pull/5216)

* [For #6556: Adds Telemetry counts for Search Access Points #7310](https://github.com/mozilla-mobile/fenix/pull/7310)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Metrics
Mozilla_products
default_moz_browser

1. Provide a link to the initial Data Collection Review Request for this collection.


* [[Waiting on Data Review] For  #1192: Adds telemetry for Mozilla products #1953](https://github.com/mozilla-mobile/fenix/pull/1953)

* [For #5214 - Bumps expiration dates for telemetry #5216](https://github.com/mozilla-mobile/fenix/pull/5216)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Metrics
toolbar_position

1. Provide a link to the initial Data Collection Review Request for this collection.


* [ For #5694 & #6054: Allows users to change toolbar position #6608](https://github.com/mozilla-mobile/fenix/pull/6608)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Metrics
Close_tab_setting
tab_view_setting

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #15347 - Adds telemetry for tab settings #15811 (comment)](https://github.com/mozilla-mobile/fenix/pull/15811#issuecomment-706402952)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Metrics
search_widget_installed

1. Provide a link to the initial Data Collection Review Request for this collection.


* [ For #9488: Add Search widget CFR & telemetry #10958](https://github.com/mozilla-mobile/fenix/pull/10958)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Metrics
Has_open_tabs
tabs_open_count

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #11479: Record open tabs count in metrics ping #12024](https://github.com/mozilla-mobile/fenix/pull/12024)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Metrics
mobile_bookmarks_count
has_mobile_bookmarks
desktop_bookmarks_count
has_desktop_bookmarks

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #16941 - [Telemetry] Bookmark Counts #16942](https://github.com/mozilla-mobile/fenix/pull/16942)

* [For #16941 - [Telemetry] Bookmark Counts #16942 (comment)](https://github.com/mozilla-mobile/fenix/pull/16942#issuecomment-742794701)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product has not been able to utilize the metrics ping and we want to keep them until they have a chance to analyze it.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Adjust_campaign

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #1298: Adds adjustCampaignId to core ping #5579](https://github.com/mozilla-mobile/fenix/pull/5579)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We will be actively using Adjust in H2.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Adjust_ad_group, Adjust_creative, adjust_network

* [For #9136: Send all adjust properties to glean #9253](https://github.com/mozilla-mobile/fenix/pull/9253)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. Provide a link to the initial Data Collection Review Request for this collection.

2. When will this collection now expire? 08/01/2022

3. Why was the initial period of collection insufficient?
   We will be actively using Adjust in H2.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

preferences:
search_suggestions_enabled
remote_debugging_enabled
telemetry_enabled
enhanced_tracking_protection
bookmarks_suggestion
browsing_history_suggestion
clipboard_suggestions_enabled
search_shortcuts_enabled
signed_in_sync
sync_items
voice_search_enabled
toolbar_position_setting
accessibility_services

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #11118: Add toggle states to metrics ping #11211](https://github.com/mozilla-mobile/fenix/pull/11211)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   These will be used when we launch MR2 to make the success dashboard.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

preferences:
Open_links_in_app_enabled
user_theme

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #11118: Add missing telemetry #11446](https://github.com/mozilla-mobile/fenix/pull/11446)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   These will be used when we launch MR2 to make the success dashboard.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

search.default_engine:
code
name
submission_url

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #800 - Adds metrics for the default search engine #1606](https://github.com/mozilla-mobile/fenix/pull/1606)

* [For #5214 - Bumps expiration dates for telemetry #5216](https://github.com/mozilla-mobile/fenix/pull/5216)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Important for revenue tracking and optimization.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

sync_auth:
opened:
closed
use_email
use_email_problem
sign_in
sign_out
sign_up
paired
recovered
other_external
scan_pairing

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #1190: Adds telemetry for FxA login #2745 (comment)](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)

* [Add 'useEmail' metrics event #9835 (review)](https://github.com/mozilla-mobile/fenix/pull/9835#pullrequestreview-398641844)

* [FxA WebChannels integration  #4931 (comment)](https://github.com/mozilla-mobile/fenix/pull/4931#issuecomment-529740300)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Important for overall strategy as it relates to the Firefox ecosystem.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

sync_account:
opened
sync_now
send_tab
sign_in_to_send_tab

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #1190: Adds telemetry for FxA login #2745 (comment)](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)

* [For #1190: Adds telemetry for FxA login #2745 (comment)](https://github.com/mozilla-mobile/fenix/pull/2745#issuecomment-494918532)

* [For #4908: Adds metrics for send tab telemetry #5106](https://github.com/mozilla-mobile/fenix/pull/5106)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Important for overall strategy as it relates to the Firefox ecosystem.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

history:
opened
removed
Removed_all
shared

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #2362: Adds telemetry for history #3940](https://github.com/mozilla-mobile/fenix/pull/3940)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We will be actively working on this in MR2.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

tip:
displayed
pressed
closed

1. Provide a link to the initial Data Collection Review Request for this collection.


* [Issue #9208: Adds in-product prompt to homescreen #9836](https://github.com/mozilla-mobile/fenix/pull/9836)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

reader_mode:
available
opened
closed
appearance

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #2267: Adds telemetry for reader mode #3941](https://github.com/mozilla-mobile/fenix/pull/3941)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)

* [For #2267: Fixes telemetry for reader view #4328](https://github.com/mozilla-mobile/fenix/pull/4328)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   This feature will be important for the next major releases (following MR2)

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Tabs_tray:
opened
closed
opened_existing_tab
closed_existing_tab
private_mode_tapped
normal_mode_tapped
synced_mode_tapped
new_tab_tapped
new_private_tab_tapped
menu_opened
save_to_collection
share_all_tabs
close_all_tabs

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #11273: Add tabs tray telemetry #12036](https://github.com/mozilla-mobile/fenix/pull/12036)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)

* [Closes #18948: Update tabstray telemetry #19004](https://github.com/mozilla-mobile/fenix/pull/19004)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We are making changes to the tabs tray during H2 2021.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

search_widget:
new_tab_button:
voice_button

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #4457: Adds telemetry for search widget actions #4714](https://github.com/mozilla-mobile/fenix/pull/4714)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Will be investigating the use of widgets in the future and will need this data to make informed decisions. This is also important for revenue tracking and optimization.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

tracking_protection:
exception_added
panel_settings
etp_shield
etp_tracker_list
etp_settings
etp_setting_changed

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #5312 - Add Telemetry for Tracking Protection #5414 (comment)](https://github.com/mozilla-mobile/fenix/pull/5414#issuecomment-532847188)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)

* [ For #11063: Update telemetry for etp settings  #11383](https://github.com/mozilla-mobile/fenix/pull/11383)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We are making changes to the tracking protection panel and settings during H2 2021. This will be part of our success metrics dashboard.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

tab:
media_play:
media_pause

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #5197: Adds telemetry for media controls #5266](https://github.com/mozilla-mobile/fenix/pull/5266)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We are continuing to make changes to how and where we are giving the users the ability to play/pause their media, so this data will give us a baseline against which we can compare those interactions.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

media_notification:
play
pause

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #5197: Adds telemetry for media notification #5520](https://github.com/mozilla-mobile/fenix/pull/5520)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We are continuing to make changes to how and where we are giving the users the ability to play/pause their media, so this data will give us a baseline against which we can compare those interactions.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

media_state:
play:
pause
stop
fullscreen
picture_in_picture

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #5705 - Adds telemetry for media state #6463](https://github.com/mozilla-mobile/fenix/pull/6463)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)

* [For #15368  - Adds telemetry for fullscreen, pip #16833](https://github.com/mozilla-mobile/fenix/pull/16833)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We are continuing to make changes to how and where we are giving the users the ability to interact with their media (e.g. play and pause), so this data will give us a baseline against which we can compare those interactions.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

logins:
open_logins:
open_individual_login
copy_login
view_password_login
save_logins_setting_changed
open_login_editor
delete_saved_login
save_edited_login

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #5586 - Adds Logins Telemetry #6352](https://github.com/mozilla-mobile/fenix/pull/6352)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)

* [For #5586 - Add telemetry for save logins setting #7767](https://github.com/mozilla-mobile/fenix/pull/7767)

* [For #10173: login duplicates and save #11208](https://github.com/mozilla-mobile/fenix/pull/11208)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Still need to optimize this feature and we want trends from 6+mo of data.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

voice_search.tapped:

1. Provide a link to the initial Data Collection Review Request for this collection.


* [ For #10465: Add telemetry for voice search  #10785](https://github.com/mozilla-mobile/fenix/pull/10785)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   This feature will be important for future initiatives and we will need historical data from 6+mo.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

top_sites:
open_default:
open_frecency
open_pinned
swipe_carousel
long_press
open_in_new_tab
open_in_private_tab
remove

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #8125: Add default top site telemetry #10752](https://github.com/mozilla-mobile/fenix/pull/10752)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)

* [For #14565: Add telemetry for top sites #15136](https://github.com/mozilla-mobile/fenix/pull/15136)

* [For #6758 - Add Top Sites to Fenix #7523](https://github.com/mozilla-mobile/fenix/pull/7523)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We are making changes to the home screen in H2 2021 and want interaction data for top sites.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

top_sites:
Open_google_search_attribution

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #17418 - Added telemetry for Google Default Top Site #17637](https://github.com/mozilla-mobile/fenix/pull/17637)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We are making changes to the home screen in H2 2021 and want interaction data for partner top sites.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

pocket:
pocket_top_site_clicked:
pocket_top_site_removed

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #8126 - Adds default top sites  #8098](https://github.com/mozilla-mobile/fenix/pull/8098)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We are making changes to the home screen in H2 2021 and want interaction data for top sites.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

first_session: campaign, network, adgroup, creative, timestamp

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #7295 - Adds new custom ping: 'installation' #8074 (comment)](https://github.com/mozilla-mobile/fenix/pull/8074#issuecomment-586512202)

* [Issue #14142 - Telemetry renewal to 08-01-2021 #15713 (comment)](https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   Product continues to monitor first session use.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

autoplay:
visited_setting:
setting_changed

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #11579 - Adds telemetry for autoplay settings in Site Permissions #13041 (comment)](https://github.com/mozilla-mobile/fenix/pull/13041#issuecomment-665777411)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   We are continuing to make changes to how and where we are giving the users the ability to interact with their media (e.g. play and pause), so this data will give us a baseline against which we can compare those interactions.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

tabs.setting_opened:

1. Provide a link to the initial Data Collection Review Request for this collection.


* [For #15347 - Adds telemetry for tab settings #15811 (comment)](https://github.com/mozilla-mobile/fenix/pull/15811#issuecomment-706402952)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   This will help us determine how (if) this is being used.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

synced_tabs:
synced_tabs_suggestion_clicked

1. Provide a link to the initial Data Collection Review Request for this collection.


* [Closes #18163: Use SyncedTabsFacts for Synced Tab Telemetry #18172](https://github.com/mozilla-mobile/fenix/pull/18172)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   This data is important so we can explore feature optimization for synced tabs.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

awesomebar:
bookmark_suggestion_clicked:
clipboard_suggestion_clicked
history_suggestion_clicked
search_action_clicked
search_suggestion_clicked
Opened_tab_suggestion_clicked

1. Provide a link to the initial Data Collection Review Request for this collection.


* [Closes #18068: Use AwesomeBarFacts for AwesomeBar Telemetry #18090](https://github.com/mozilla-mobile/fenix/pull/18090)

* [For #19923: renew telemetry probes #19924 (comment)](https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789)


1. When will this collection now expire? 08/01/2022

2. Why was the initial period of collection insufficient?
   This data is important so we can explore feature optimization for the awesomebar

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

@travis79 travis79 removed the needs:data-review PR is awaiting a data review label Jul 29, 2021
@travis79
Copy link
Member

😅 Whew!

app/metrics.yaml Outdated
@@ -430,12 +430,13 @@ onboarding:
- https://github.com/mozilla-mobile/fenix/pull/11867
- https://github.com/mozilla-mobile/fenix/pull/15713#issuecomment-703972068
- https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789
- https://github.com/mozilla-mobile/fenix/pull/TBD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming we will update these TBD before landing.

@eliserichards
Copy link
Contributor Author

eliserichards commented Jul 29, 2021

test-debug keeps failing for different classes with this:

io.mockk.MockKException: Can't instantiate proxy for class kotlin.Function0
	at io.mockk.impl.instantiation.JvmMockFactory.newProxy(JvmMockFactory.kt:64)
	at io.mockk.impl.instantiation.AbstractMockFactory.newProxy$default(AbstractMockFactory.kt:29)
	at io.mockk.impl.instantiation.AbstractMockFactory.mockk(AbstractMockFactory.kt:59)
	at io.mockk.impl.annotations.JvmMockInitializer.assignMockK(JvmMockInitializer.kt:163)
	at io.mockk.impl.annotations.JvmMockInitializer.initMock(JvmMockInitializer.kt:41)
	at io.mockk.impl.annotations.JvmMockInitializer.initAnnotatedMocks(JvmMockInitializer.kt:24)
	at org.mozilla.fenix.tabstray.DefaultTabsTrayControllerTest.setup(DefaultTabsTrayControllerTest.kt:427)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:570)
	at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:278)
	at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:89)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: io.mockk.proxy.MockKAgentException: Failed to subclass interface kotlin.jvm.functions.Function0
	at io.mockk.proxy.jvm.ProxyMaker.proxy(ProxyMaker.kt:38)
	at io.mockk.impl.instantiation.JvmMockFactory.newProxy(JvmMockFactory.kt:34)
	... 21 more
Caused by: java.lang.IllegalArgumentException: Could not create type
	at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:155)
	at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:175)
	at io.mockk.proxy.jvm.transformation.SubclassInstrumentation.subclass(SubclassInstrumentation.kt:51)
	at io.mockk.proxy.jvm.ProxyMaker.subclass(ProxyMaker.kt:113)
	at io.mockk.proxy.jvm.ProxyMaker.proxy(ProxyMaker.kt:35)
	... 22 more
Caused by: java.lang.IllegalStateException: Failed to invoke proxy for public abstract java.lang.Class net.bytebuddy.dynamic.loading.ClassInjector$UsingLookup$MethodHandles$Lookup.defineClass(java.lang.Object,byte[]) throws java.lang.IllegalAccessException
	at net.bytebuddy.utility.dispatcher.JavaDispatcher$ProxiedInvocationHandler.invoke(JavaDispatcher.java:1123)
	at com.sun.proxy.$Proxy52.defineClass(Unknown Source)
	at net.bytebuddy.dynamic.loading.ClassInjector$UsingLookup.injectRaw(ClassInjector.java:1621)
	at net.bytebuddy.dynamic.loading.ClassInjector$AbstractBase.inject(ClassInjector.java:113)
	at net.bytebuddy.dynamic.loading.ClassLoadingStrategy$UsingLookup.load(ClassLoadingStrategy.java:492)
	at net.bytebuddy.dynamic.TypeResolutionStrategy$Passive.initialize(TypeResolutionStrategy.java:100)
	at net.bytebuddy.dynamic.DynamicType$Default$Unloaded.load(DynamicType.java:6147)
	at io.mockk.proxy.jvm.transformation.SubclassInstrumentation.doInterceptedSubclassing(SubclassInstrumentation.kt:98)
	at io.mockk.proxy.jvm.transformation.SubclassInstrumentation.access$doInterceptedSubclassing(SubclassInstrumentation.kt:21)
	at io.mockk.proxy.jvm.transformation.SubclassInstrumentation$subclass$1.call(SubclassInstrumentation.kt:54)
	at io.mockk.proxy.jvm.transformation.SubclassInstrumentation$subclass$1.call(SubclassInstrumentation.kt:21)
	at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:153)
	... 26 more
Caused by: java.lang.LinkageError: loader 'app' attempted duplicate class definition for kotlin.jvm.functions.Function0$Subclass28. (kotlin.jvm.functions.Function0$Subclass28 is in unnamed module of loader 'app')
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.System$2.defineClass(System.java:2131)
	at java.base/java.lang.invoke.MethodHandles$Lookup.defineClass(MethodHandles.java:962)
	at java.base/jdk.internal.reflect.GeneratedMethodAccessor23.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at net.bytebuddy.utility.dispatcher.JavaDispatcher$Invoker$Dispatcher.invoke(Unknown Source)
	at net.bytebuddy.utility.dispatcher.JavaDispatcher$Dispatcher$ForNonStaticMethod.invoke(JavaDispatcher.java:986)
	at net.bytebuddy.utility.dispatcher.JavaDispatcher$ProxiedInvocationHandler.invoke(JavaDispatcher.java:1110)
	... 37 more

🤔

@eliserichards eliserichards added pr:approved PR that has been approved pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Jul 29, 2021
@mergify mergify bot merged commit a901341 into mozilla-mobile:main Jul 29, 2021
eliserichards added a commit to eliserichards/fenix that referenced this pull request Aug 2, 2021
…August (mozilla-mobile#20517)

* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Aug 2, 2021
* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
czlucius pushed a commit to czlucius/fenix that referenced this pull request Aug 20, 2021
…August (mozilla-mobile#20517)

* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
czlucius pushed a commit to czlucius/fenix that referenced this pull request Aug 22, 2021
…August (mozilla-mobile#20517)

* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
eliserichards added a commit that referenced this pull request Aug 24, 2021
* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
eliserichards added a commit to eliserichards/fenix that referenced this pull request Aug 24, 2021
…August (mozilla-mobile#20517)

* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry] Renew probes expiring in August
3 participants