Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Issue #11886: Test remove codecov (workaround) #11928

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Issue #11886: Test remove codecov (workaround) #11928

merged 1 commit into from
Jun 24, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Jun 24, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ekager ekager requested a review from liuche June 24, 2020 23:15
liuche
liuche approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@liuche liuche left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backing out codecov for some script breakage upstream #11886 - may need releng's help with some workarounds, but we need to land things for code freeze.

@liuche liuche merged commit 42098d9 into mozilla-mobile:master Jun 24, 2020
@liuche liuche changed the title No issue: Test remove codecov Issue #11886: Test remove codecov (workaround) Jun 24, 2020
@liuche liuche mentioned this pull request Jun 24, 2020
Closed
liuche pushed a commit to liuche/fenix that referenced this pull request Jun 25, 2020
@ekager @liuche
No issue: Test remove codecov (mozilla-mobile#11928)
d6b3e07
@liuche liuche mentioned this pull request Jun 25, 2020
Merged
4 tasks
liuche pushed a commit to liuche/fenix that referenced this pull request Jun 25, 2020
@ekager @liuche
No issue: Test remove codecov (mozilla-mobile#11928)
fb7fbee
liuche pushed a commit to liuche/fenix that referenced this pull request Jun 25, 2020
@ekager @liuche
No issue: Test remove codecov (mozilla-mobile#11928)
7701ea9
liuche added a commit that referenced this pull request Jun 25, 2020
@liuche @ekager
Revert "For #9946: Update FennecBeta branding (#10066)" to push to Fi…
d84f48a 
…refox Beta (#11872)

* Revert "For #9946: Update FennecBeta branding (#10066)" to push to Firefox Beta.

This reverts commit 95f26f1.

* No issue: Test remove codecov (#11928)

Co-authored-by: Emily Kager <emilykager@gmail.com>
@liuche liuche mentioned this pull request Jun 27, 2020
Closed
12 tasks
pocmo pushed a commit that referenced this pull request Jun 30, 2020
@liuche @ekager @pocmo
Revert "For #9946: Update FennecBeta branding (#10066)" to push to Fi…
a3df736 
…refox Beta (#11872)

* Revert "For #9946: Update FennecBeta branding (#10066)" to push to Firefox Beta.

This reverts commit 95f26f1.

* No issue: Test remove codecov (#11928)

Co-authored-by: Emily Kager <emilykager@gmail.com>
@ekager ekager deleted the remove-codecov branch August 21, 2020 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuche liuche liuche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekager @liuche