Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11392: Rename Installation ping to FirstSession #11869

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Jun 23, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz marked this pull request as ready for review June 24, 2020 20:08
@sblatz sblatz changed the title Example For #11392: Rename Installation ping to FirstSession Jun 24, 2020
@sblatz sblatz requested review from liuche and boek and removed request for liuche June 24, 2020 20:11
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me, renaming of the session.

May need to rebase this off master to get the codecov fix.

@liuche
Copy link
Contributor

liuche commented Jun 25, 2020

@sblatz I also need a PR against the releases/78.0.0 branch with this change, PLUS the removing GAID change. I'm currently making the branding change in #11872 + codecov breakage fix, so you could either wait for that to land and then rebase, or cherry-pick the codecov commit that fixes the broken CI (#11928 )

@sblatz sblatz merged commit 2d65faf into mozilla-mobile:master Jun 25, 2020
@liuche liuche mentioned this pull request Jun 27, 2020
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants