Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #12002: Show default tab background when thumbnail not available #12041

Merged
merged 1 commit into from Jun 27, 2020

Conversation

jonalmeida
Copy link
Contributor

Adds a default thumbnail background when we do not have one created yet (specifically after a migration).

3

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@jonalmeida jonalmeida requested a review from darkwing June 26, 2020 23:15
@darkwing darkwing added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Jun 27, 2020
@jonalmeida
Copy link
Contributor Author

Random test failure: GIVEN sharedprefs contains installed engines WHEN installedSearchEngineIdentifiers THEN defaultEngines + customEngines ids are returned

@jonalmeida
Copy link
Contributor Author

Filed #12042 for the failing intermittent test.

@liuche liuche closed this Jun 27, 2020
@liuche liuche reopened this Jun 27, 2020
@jonalmeida jonalmeida merged commit f89b157 into mozilla-mobile:master Jun 27, 2020
@jonalmeida
Copy link
Contributor Author

Thanks liuche for restarting it, forgot to do that.

@liuche liuche mentioned this pull request Jun 27, 2020
12 tasks
@jonalmeida jonalmeida deleted the issue-12002 branch June 27, 2020 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants