-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #8312 - Show Top Sites in a ViewPager #14116
Conversation
This follows the approach that is used in Firefox Lite mozilla-mobile/FirefoxLite@7d7be8e. The Top site layout is as follow: The We removed the dependency on The proper layout of the items and grid will be done in #13765. |
Codecov Report
@@ Coverage Diff @@
## master #14116 +/- ##
============================================
- Coverage 29.78% 29.67% -0.11%
+ Complexity 1135 1133 -2
============================================
Files 437 440 +3
Lines 17565 17616 +51
Branches 2280 2289 +9
============================================
- Hits 5231 5227 -4
- Misses 11950 12004 +54
- Partials 384 385 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ w nits
Fixes #8312
Pull Request checklist
After merge
To download an APK when reviewing a PR: