Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Issue #9295 - Add back non-blocking bors to trigger CI on contributor… #14967

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

liuche
Copy link
Contributor

@liuche liuche commented Sep 10, 2020

… PRs (#9843)

Co-authored-by: Johan Lorenzo jlorenzo@mozilla.com

Got approval to add this back! 🙏 @st3fan !

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

…on contributor PRs (mozilla-mobile#9843)

Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
@codecov-commenter
Copy link

Codecov Report

Merging #14967 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #14967   +/-   ##
=========================================
  Coverage     29.58%   29.58%           
  Complexity     1154     1154           
=========================================
  Files           447      447           
  Lines         18215    18215           
  Branches       2371     2371           
=========================================
  Hits           5389     5389           
+ Misses        12452    12451    -1     
- Partials        374      375    +1     
Impacted Files Coverage Δ Complexity Δ
...mponents/searchengine/FenixSearchEngineProvider.kt 63.96% <0.00%> (ø) 13.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a6bb95...6635633. Read the comment docs.

@liuche
Copy link
Contributor Author

liuche commented Sep 18, 2020

@JohanLorenzo let me know if this is something we could get in!

@JohanLorenzo
Copy link
Contributor

Yes, it definitely is! Sorry, I wanted to get this landed this week, but I got sidetracked. I'll merge it on my Monday morning!

Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Okay to give bors another try!

@JohanLorenzo JohanLorenzo merged commit 4b410d8 into mozilla-mobile:master Sep 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants