Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Issue #9295 - Add back non-blocking bors to trigger CI on contributor PRs #9843

Merged
merged 3 commits into from
Apr 10, 2020

Conversation

liuche
Copy link
Contributor

@liuche liuche commented Apr 10, 2020

Added bors back to taskcluster scripts, and updating some of the trigger/block parameters.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@firefoxci-taskcluster
Copy link

Submitting the task to Taskcluster failed. Details

bad indentation of a mapping entry at line 25, column 31:
$if: 'tasks_for == "github-pull- ...
^

1 similar comment
@firefoxci-taskcluster
Copy link

Submitting the task to Taskcluster failed. Details

bad indentation of a mapping entry at line 25, column 31:
$if: 'tasks_for == "github-pull- ...
^

@firefoxci-taskcluster
Copy link

Submitting the task to Taskcluster failed. Details

can not read a block mapping entry; a multiline key may not be an implicit key at line 26, column 34:
$if: 'tasks_for == "github-pull-req ...
^

.taskcluster.yml Outdated Show resolved Hide resolved
@JohanLorenzo
Copy link
Contributor

bors try

@JohanLorenzo
Copy link
Contributor

bors try

I guess this PR needs to be merged before bors actually takes on requests. I'll try this out with #9826

@codecov-io
Copy link

Codecov Report

Merging #9843 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9843      +/-   ##
============================================
+ Coverage     19.14%   19.16%   +0.01%     
  Complexity      521      521              
============================================
  Files           337      337              
  Lines         13708    13708              
  Branches       1838     1838              
============================================
+ Hits           2625     2627       +2     
+ Misses        10843    10842       -1     
+ Partials        240      239       -1     
Impacted Files Coverage Δ Complexity Δ
...ix/home/sessioncontrol/SessionControlController.kt 72.72% <0.00%> (+0.90%) 0.00% <0.00%> (ø%)
...c/main/java/org/mozilla/fenix/components/Search.kt 100.00% <0.00%> (+8.33%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31c198...596e466. Read the comment docs.

Copy link
Contributor

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me! I think bors won't block any regular merges while still allowing bors try to run. Thanks for taking care of it @liuche 😃

@JohanLorenzo JohanLorenzo merged commit b897039 into mozilla-mobile:master Apr 10, 2020
JohanLorenzo added a commit that referenced this pull request Apr 10, 2020
@liuche liuche deleted the add-bors branch April 10, 2020 16:06
liuche pushed a commit that referenced this pull request Apr 10, 2020
@liuche liuche mentioned this pull request Apr 13, 2020
32 tasks
liuche added a commit that referenced this pull request Apr 13, 2020
… PRs (#9843)

Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
liuche pushed a commit that referenced this pull request Apr 13, 2020
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
liuche added a commit to liuche/fenix that referenced this pull request Sep 10, 2020
…on contributor PRs (mozilla-mobile#9843)

Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
JohanLorenzo added a commit that referenced this pull request Sep 21, 2020
… PRs (#9843) (#14967)

Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants