Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Issue #15731 - Enable tg on release locales. #15984

Merged
merged 1 commit into from Oct 17, 2020

Conversation

liuche
Copy link
Contributor

@liuche liuche commented Oct 16, 2020

We needed to add tg to the release locales list so that it will be built in release builds. Will need uplift to 82-RC.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@liuche liuche requested review from a team as code owners October 16, 2020 23:40
@liuche liuche added the needs:uplift Issue / PR needs to be uplifted to the release branch label Oct 16, 2020
@liuche liuche mentioned this pull request Oct 16, 2020
2 tasks
@liuche liuche added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Oct 17, 2020
@gabrielluong gabrielluong added the pr:approved PR that has been approved label Oct 17, 2020
@liuche
Copy link
Contributor Author

liuche commented Oct 17, 2020

Seems like we're hitting some timeouts - these tests are definitely taking a very long time.

SUITE: org.mozilla.fenix.browser.browsingmode.DefaultBrowsingModeManagerTest
TEST: WHEN mode is updated THEN it should be returned from get
[taskcluster:error] Task timeout after 7200 seconds. Force killing container.
[taskcluster 2020-10-17 01:44:17.239Z] === Task Finished ===

https://firefox-ci-tc.services.mozilla.com/tasks/D7ga8CQpQjO6jwq7BNT_vA

@liuche liuche closed this Oct 17, 2020
@liuche liuche reopened this Oct 17, 2020
@liuche liuche removed the needs:uplift Issue / PR needs to be uplifted to the release branch label Oct 17, 2020
@gabrielluong gabrielluong reopened this Oct 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #15984 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #15984   +/-   ##
=========================================
  Coverage     29.85%   29.85%           
  Complexity     1190     1190           
=========================================
  Files           453      453           
  Lines         18542    18542           
  Branches       2405     2405           
=========================================
  Hits           5536     5536           
  Misses        12612    12612           
  Partials        394      394           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319abf3...97c9ccf. Read the comment docs.

@gabrielluong gabrielluong merged commit 259ec95 into mozilla-mobile:master Oct 17, 2020
@Mugurell Mugurell mentioned this pull request Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants