This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Closes #16345: Standartizing share icon across all app #16536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace mozac_ic_share for ic_hollow_share on DefaultToolbarMenu
updating share icon to a filled shape, like default toolbar menu across all app
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
ekager
suggested changes
Nov 12, 2020
| contentDescription = context.getString(R.string.browser_menu_share), | ||
| iconTintColorResource = primaryTextColor(), | ||
| listener = { | ||
| onItemTapped.invoke(ToolbarMenu.Item.Share) | ||
| } | ||
| ) | ||
|
|
||
| registerForIsBookmarkedUpdates() |
There was a problem hiding this comment.
Don't know, putting it back
You're right, but |
… for bookmark changes comment link: mozilla-mobile#16536 (comment)
|
bors try |
tryBuild succeeded: |
ekager
approved these changes
Nov 13, 2020
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2020
16536: Closes #16345: Standartizing share icon across all app r=ekager a=LeoMaldonado ### Pull Request checklist <!-- Before submitting the PR, please address each item --> - [x] **Tests**: This PR includes thorough tests or an explanation of why it does not - [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not - [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features. In addition, it includes a screenshot of a successful [accessibility scan](https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor&hl=en_US) to ensure no new defects are added to the product. ### To download an APK when reviewing a PR: 1. click on Show All Checks, 2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark, 3. click on the "Fenix - assemble" task, then click "Run Artifacts". 4. the APK links should be on the left side of the screen, named for each CPU architecture This PR closes #16345. I removed share icon outlined by a filled share icon and put it in all references to share icons.    Co-authored-by: LeoMaldonado <leomaldonadopassos@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #16536 +/- ##
=========================================
Coverage 29.93% 29.93%
Complexity 1216 1216
=========================================
Files 455 455
Lines 18696 18696
Branches 2571 2571
=========================================
Hits 5596 5596
Misses 12665 12665
Partials 435 435
Continue to review full report at Codecov.
|
|
Merged, thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
To download an APK when reviewing a PR:
This PR closes #16345. I removed share icon outlined by a filled share icon and put it in all references to share icons.