-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #16828 - Adds telemetry for open in app banner #17049
For #16828 - Adds telemetry for open in app banner #17049
Conversation
82a3b05
to
5c78add
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection. 1) What questions will you answer with this data?
2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? 3) What alternative methods did you consider to answer these questions? Why were they not sufficient? 4) Can current instrumentation answer these questions? 5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki. Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
6) Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way. 7) How long will this data be collected? Choose one of the following: 8) What populations will you measure? 9) If this data collection is default on, what is the opt-out mechanism for users? 10) Please provide a general description of how you will analyze this data. 11) Where do you intend to share the results of your analysis? 12) Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection? |
This pull request has conflicts when rebasing. Could you fix it @codrut-topliceanu? 🙏 |
5c78add
to
030fc02
Compare
This pull request has conflicts when rebasing. Could you fix it @codrut-topliceanu? 🙏 |
86eba73
to
06b580d
Compare
Codecov Report
@@ Coverage Diff @@
## master #17049 +/- ##
============================================
- Coverage 30.81% 30.76% -0.06%
- Complexity 1239 1241 +2
============================================
Files 455 455
Lines 18668 18680 +12
Branches 2615 2622 +7
============================================
- Hits 5753 5747 -6
- Misses 12453 12470 +17
- Partials 462 463 +1
Continue to review full report at Codecov.
|
@boek Hey, would you mind taking a look at this? 🙏 |
This pull request has conflicts when rebasing. Could you fix it @codrut-topliceanu? 🙏 |
@kglazko Could you help with a data review please ? 🥺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change 😄
Specifically: Banner displayed, Dismiss action, Go to Settings action.
06b580d
to
f508583
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! Once we get a data review approval this will be ready to merge! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, metrics.yaml and metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, data collection settings -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2 -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice? If unsure: escalate to legal if:
Yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Fenix team will check-in at expiry -
Does the data collection use a third-party collection tool?
No
…illa-mobile#17049) * For mozilla-mobile#16828 - Adds telemetry for open in app banner Specifically: Banner displayed, Dismiss action, Go to Settings action.
Specifically: Banner displayed, Dismiss action, Go to Settings action.
For #16828
Pull Request checklist
To download an APK when reviewing a PR: