Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #15703 and #17133: allow ETP redirect trackers setting to be customized #17137

Merged
merged 2 commits into from
Dec 22, 2020
Merged

For #15703 and #17133: allow ETP redirect trackers setting to be customized #17137

merged 2 commits into from
Dec 22, 2020

Conversation

eliserichards
Copy link
Contributor

@eliserichards eliserichards commented Dec 18, 2020 •
edited

For #15703, #17133

  • add clickable Redirect Trackers category to the ETP panel on toolbar
  • add Redirect Trackers selectable ✅ category to CUSTOM list in settings ([UX] ETP Cookie purging #13812 only added it to the (i) info lists for standard, strict, and custom)
  • add/remove from CUSTOM (i) list to match others when ✅ checked
  • tests

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards
Copy link
Contributor Author

image image

@eliserichards eliserichards added the needs:review PRs that need to be reviewed label Dec 18, 2020
@eliserichards eliserichards marked this pull request as ready for review December 21, 2020 16:49
@eliserichards eliserichards requested review from a team as code owners December 21, 2020 16:49
rocketsroger
rocketsroger approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@rocketsroger rocketsroger added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Dec 22, 2020
@eliserichards eliserichards merged commit 6dadeca into mozilla-mobile:master Dec 22, 2020
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 4, 2021
@eliserichards @pkirakosyan
For mozilla-mobile#15703 and mozilla-mobile#17133: allow ETP redirect…
c73101c 
… trackers setting to be customized (mozilla-mobile#17137)

* Remove ETP redirect trackers feature flag. Add category to ETP panel view.

* Add redirect tracker category to ETP custom settings
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rocketsroger rocketsroger rocketsroger approved these changes

Assignees
No one assigned
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliserichards @rocketsroger