Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #16485: Tabs tray grid view telemetry #17442

Merged
merged 3 commits into from
Jan 25, 2021
Merged

For #16485: Tabs tray grid view telemetry #17442

merged 3 commits into from
Jan 25, 2021

Conversation

eliserichards
Copy link
Contributor

@eliserichards eliserichards commented Jan 13, 2021 •
edited
Loading

For #16485

  • create Events in metrics.yaml
  • implement events
  • documentation

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards requested review from a team as code owners January 13, 2021 19:58
@eliserichards eliserichards added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Jan 13, 2021
@eliserichards eliserichards changed the title For #16485: Tabs tray gid view telemetry For #16485: Tabs tray grid view telemetry Jan 13, 2021
@codecov-io
Copy link

codecov-io commented Jan 13, 2021 •
edited
Loading

Codecov Report

Merging #17442 (95d65ec) into master (023ddcc) will decrease coverage by 0.25%.
The diff coverage is 10.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17442      +/-   ##
============================================
- Coverage     32.55%   32.30%   -0.26%     
+ Complexity     1313     1290      -23     
============================================
  Files           455      456       +1     
  Lines         19065    18955     -110     
  Branches       2662     2644      -18     
============================================
- Hits           6207     6123      -84     
+ Misses        12367    12349      -18     
+ Partials        491      483       -8
Impacted Files Coverage Δ Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt 12.20% <0.00%> (-0.14%) 5.00 <0.00> (ø)
...main/java/org/mozilla/fenix/tabtray/TabTrayView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/org/mozilla/fenix/components/metrics/Event.kt 33.54% <50.00%> (-0.01%) 0.00 <0.00> (ø)
...ava/org/mozilla/fenix/tabtray/TabTrayController.kt 78.57% <100.00%> (+4.65%) 0.00 <0.00> (ø)
...ssions/SitePermissionsDetailsExceptionsFragment.kt 0.00% <0.00%> (-32.82%) 0.00% <0.00%> (-5.00%)
...PermissionsManageExceptionsPhoneFeatureFragment.kt 0.00% <0.00%> (-28.72%) 0.00% <0.00%> (-12.00%)
...ntrol/viewholders/topsites/TopSitesPagerAdapter.kt 0.00% <0.00%> (-22.73%) 0.00% <0.00%> (ø%)
...g/mozilla/fenix/tabhistory/TabHistoryController.kt 85.71% <0.00%> (-14.29%) 0.00% <0.00%> (ø%)
...la/fenix/customtabs/FennecWebAppIntentProcessor.kt 0.00% <0.00%> (-11.63%) 0.00% <0.00%> (-5.00%)
...org/mozilla/fenix/search/SearchDialogInteractor.kt 91.66% <0.00%> (-8.34%) 11.00% <0.00%> (ø%)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023ddcc...7da56ab. Read the comment docs.

@eliserichards eliserichards added needs:review PRs that need to be reviewed and removed pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Jan 13, 2021
@eliserichards
Copy link
Contributor Author

UI test failures are unrelated. Re-starting CI.

@eliserichards
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Jan 13, 2021
@MozLando
Try #17442:
b908664
@bors
Copy link

bors bot commented Jan 13, 2021

try

Build succeeded:

@eliserichards eliserichards reopened this Jan 14, 2021
@Amejia481 Amejia481 self-requested a review January 14, 2021 21:35
@Amejia481 Amejia481 self-assigned this Jan 14, 2021
@eliserichards eliserichards added pr:do-not-land 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed needs:review PRs that need to be reviewed labels Jan 19, 2021
@eliserichards
Copy link
Contributor Author

Waiting on a data review, then this will be ready to land.

@boek boek removed pr:do-not-land 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Jan 20, 2021
@boek
Copy link
Contributor

boek commented Jan 20, 2021

R+ #16485 (comment)

@mergify
Copy link
Contributor

mergify bot commented Jan 21, 2021

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

@gabrielluong gabrielluong added the pr:approved PR that has been approved label Jan 22, 2021
@eliserichards eliserichards merged commit f7b7b25 into mozilla-mobile:master Jan 25, 2021
@eliserichards eliserichards mentioned this pull request Jul 26, 2021
Merged
3 tasks
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 4, 2021
@eliserichards @pkirakosyan
For mozilla-mobile#16485: Tabs tray grid view telemetry (mozilla-mobi…
b85d4d3 
…le#17442)

* Tabs tray CFR telemetry interactions

* Create CFR events and implementation

* Tests for tab tray controller
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Amejia481 Amejia481 Amejia481 approved these changes

Assignees

@Amejia481 Amejia481

Labels
pr:approved PR that has been approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eliserichards @codecov-io @boek @Amejia481 @gabrielluong