Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #17770: New tab three-dot menu reorder #18427

Merged
merged 5 commits into from
Mar 31, 2021

Conversation

eliserichards
Copy link
Contributor

@eliserichards eliserichards commented Mar 10, 2021

For #17770

Adds feature flag to hide Request Desktop Site until #17800 is implemented.

Screenshots

Light mode, dark mode

With Quit item

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards requested review from a team as code owners March 10, 2021 22:33
@eliserichards eliserichards added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Mar 10, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2021

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

@gabrielluong
Copy link
Member

@eliserichards is this still a draft?

@gabrielluong gabrielluong added pr:approved PR that has been approved and removed pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Mar 12, 2021
@eliserichards eliserichards added the pr:waiting-for-authors PR that has been approved and awaiting any changes before they can land label Mar 15, 2021
@eliserichards eliserichards force-pushed the 17770-new-tab-menu branch 2 times, most recently from 2df4274 to 57560b4 Compare March 22, 2021 22:29
@eliserichards eliserichards removed the pr:waiting-for-authors PR that has been approved and awaiting any changes before they can land label Mar 22, 2021
@eliserichards eliserichards force-pushed the 17770-new-tab-menu branch 2 times, most recently from 0d4136d to 1ccc7e8 Compare March 22, 2021 23:19
@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2021

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

@codecov-io
Copy link

codecov-io commented Mar 23, 2021

Codecov Report

Merging #18427 (9882a6c) into master (2687092) will increase coverage by 0.87%.
The diff coverage is 30.41%.

❗ Current head 9882a6c differs from pull request most recent head 3e4e121. Consider uploading reports for the commit 3e4e121 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18427      +/-   ##
============================================
+ Coverage     33.45%   34.32%   +0.87%     
+ Complexity     1435     1425      -10     
============================================
  Files           499      476      -23     
  Lines         20504    20161     -343     
  Branches       3094     3056      -38     
============================================
+ Hits           6860     6921      +61     
+ Misses        12796    12397     -399     
+ Partials        848      843       -5     
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 100.00% <ø> (ø) 7.00 <0.00> (ø)
...components/toolbar/BrowserToolbarMenuController.kt 61.78% <0.00%> (+1.57%) 0.00 <0.00> (ø)
...lla/fenix/components/toolbar/BrowserToolbarView.kt 51.21% <0.00%> (+0.41%) 18.00 <0.00> (ø)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 3.48% <0.00%> (+0.02%) 6.00 <0.00> (ø)
...p/src/main/java/org/mozilla/fenix/home/HomeMenu.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lla/fenix/components/toolbar/DefaultToolbarMenu.kt 42.49% <68.50%> (+39.18%) 18.00 <15.00> (+16.00)
...g/mozilla/fenix/components/PerformanceComponent.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../org/mozilla/fenix/perf/VisualCompletenessQueue.kt 0.00% <0.00%> (-40.00%) 0.00% <0.00%> (-1.00%)
...a/fenix/downloads/DynamicDownloadDialogBehavior.kt 63.63% <0.00%> (-8.71%) 14.00% <0.00%> (-5.00%)
...ers/onboarding/OnboardingManualSignInViewHolder.kt 92.30% <0.00%> (-7.70%) 2.00% <0.00%> (ø%)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2687092...3e4e121. Read the comment docs.

@eliserichards
Copy link
Contributor Author

Failing tests:

  • testPageReloadAfterNetworkInterrupted
  • mainMenuShareButtonTest
  • mainMenuRefreshButtonTest

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2021

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

@eliserichards eliserichards force-pushed the 17770-new-tab-menu branch 2 times, most recently from 3e4e121 to 4a48f66 Compare March 31, 2021 16:29
Add todos for UI test issue 17979

Add todos for UI tests
@eliserichards eliserichards merged commit ca33aef into mozilla-mobile:master Mar 31, 2021
@eliserichards eliserichards linked an issue Apr 6, 2021 that may be closed by this pull request
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Reorder New Tab three-dot menu and add navigation
4 participants