-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #17770: New tab three-dot menu reorder #18427
For #17770: New tab three-dot menu reorder #18427
Conversation
app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
Show resolved
Hide resolved
4e4efe0
to
453dc88
Compare
This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏 |
@eliserichards is this still a draft? |
2df4274
to
57560b4
Compare
0d4136d
to
1ccc7e8
Compare
This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏 |
1ccc7e8
to
1957a0e
Compare
1957a0e
to
9882a6c
Compare
Codecov Report
@@ Coverage Diff @@
## master #18427 +/- ##
============================================
+ Coverage 33.45% 34.32% +0.87%
+ Complexity 1435 1425 -10
============================================
Files 499 476 -23
Lines 20504 20161 -343
Branches 3094 3056 -38
============================================
+ Hits 6860 6921 +61
+ Misses 12796 12397 -399
+ Partials 848 843 -5 Continue to review full report at Codecov.
|
Failing tests:
|
808da88
to
1ad1e63
Compare
c757c69
to
710a398
Compare
710a398
to
2e09f14
Compare
This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏 |
…s needed. Make new tab menu and browser menu consistent.
3e4e121
to
4a48f66
Compare
Add todos for UI test issue 17979 Add todos for UI tests
4a48f66
to
3212716
Compare
For #17770
Adds feature flag to hide Request Desktop Site until #17800 is implemented.
Screenshots
Light mode, dark mode
![](https://user-images.githubusercontent.com/43795363/112061692-dc8d4600-8b2c-11eb-8b8b-3b8fb8d10127.png)
With Quit item
![](https://user-images.githubusercontent.com/43795363/112061701-df883680-8b2c-11eb-813a-d85cc160b9b7.png)
Pull Request checklist
To download an APK when reviewing a PR: