This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Properly quote descriptions in ad metric definitions #19243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pedantic, but strictly something called <provider-name> is considered an HTML tag unless it's in a code block (backticks). See mozilla/glean-dictionary#549 and mozilla/glean-dictionary#497. I'm going to fix this upstream but figured I might as well file a PR here to fix the underlying issue.
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
3 tasks
gabrielluong
approved these changes
Apr 26, 2021
gabrielluong
added
pr:approved
PR that has been approved
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
labels
Apr 26, 2021
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #19243 +/- ##
============================================
- Coverage 34.84% 34.84% -0.01%
+ Complexity 1653 1652 -1
============================================
Files 543 543
Lines 22006 22031 +25
Branches 3295 3301 +6
============================================
+ Hits 7669 7677 +8
- Misses 13430 13445 +15
- Partials 907 909 +2
Continue to review full report at Codecov.
|
mcarare
added a commit
to mcarare/fenix
that referenced
this pull request
Apr 27, 2021
gabrielluong
pushed a commit
that referenced
this pull request
Apr 27, 2021
pkirakosyan
pushed a commit
to gexsi/user-agent-android
that referenced
this pull request
Aug 10, 2021
…9243) This is pedantic, but strictly something called <provider-name> is considered an HTML tag unless it's in a code block (backticks). See mozilla/glean-dictionary#549 and mozilla/glean-dictionary#497. I'm going to fix this upstream but figured I might as well file a PR here to fix the underlying issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
pr:approved
PR that has been approved
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pedantic, but strictly something called
<provider-name>
is considered an HTML tagunless it's in a code block (backticks). This can cause problems with downstream consumers like the glean dictionary unless we work around it there:
See mozilla/glean-dictionary#549 and mozilla/glean-dictionary#497. I'm working around this downstream in the glean dictionary now (I suspect this is going to crop up again and don't want to go around fixing this everywhere) but figured I might as well file a PR here while I was at it.
FWIW you can view this metric here: https://dictionary.protosaur.dev/apps/fenix/metrics/browser_search_ad_clicks
Pull Request checklist
To download an APK when reviewing a PR: