For #18711: Telemetry for credit card autofill

[eliserichards]

For #18711

Waiting on DS confirmation: https://jira.mozilla.com/browse/DS-1598 ✅
Needs data review: #19548 (comment) ✅
AC Facts for autofill: mozilla-mobile/android-components#10342 ✅

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[eliserichards]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?

   • This data will help us understand how users are interacting with credit cards and how they are using our autofill service. 

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
   • We are building out our services to include credit cards storage and autofill, and we need to know how useful this is for the users and how we can best serve them when it comes to their shopping experiences. This data will help us establish a baseline to make product decisions as we build out these services.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

   • There are no other alternatives.

4. Can current instrumentation answer these questions?

   • No.

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description	Data Collection Category	Tracking Bug #
Credit card manual save: A counter of the number of credit cards that have been saved manually by the user.	Category 2 - interaction data	#18711
Credit card delete: A counter of the number of credit cards that have been deleted by the user.	Category 2 - interaction data	#18711
Credit card autofill: A counter of the number of times the user has autofilled a credit card.	Category 2 - interaction data	#18711

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
   • https://dictionary.telemetry.mozilla.org/apps/fenix

7. How long will this data be collected? Choose one of the following:
   • I want this data to be collected for 6 months initially (ending on Oct 1, 2021), with the option to renew at that point.

8. What populations will you measure?
   • All channels, all locales, all countries

9. If this data collection is default on, what is the opt-out mechanism for users?

   • Default Glean SDK opt-out mechanism.

10. Please provide a general description of how you will analyze this data.

    • Glean and Amplitude.

11. Where do you intend to share the results of your analysis?
    • 
Only on Glean, Amplitude, and with mobile teams.

12. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?

    • No third-party tools.

[codecov-commenter]

Codecov Report

Merging #19548 (2c79736) into master (a69a8f2) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master   #19548      +/-   ##
============================================
- Coverage     35.42%   35.42%   -0.01%     
- Complexity     1648     1649       +1     
============================================
  Files           545      545              
  Lines         22030    22045      +15     
  Branches       3267     3271       +4     
============================================
+ Hits           7805     7809       +4     
- Misses        13326    13334       +8     
- Partials        899      902       +3     

Impacted Files	Coverage Δ
...la/fenix/components/metrics/GleanMetricsService.kt	19.66% <0.00%> (-0.23%)	⬇️
...zilla/fenix/components/metrics/MetricController.kt	34.22% <0.00%> (-0.47%)	⬇️
...x/settings/creditcards/CreditCardEditorFragment.kt	0.00% <0.00%> (ø)
...java/org/mozilla/fenix/components/metrics/Event.kt	41.36% <66.66%> (+0.20%)	⬆️
...editcards/controller/CreditCardEditorController.kt	44.44% <100.00%> (+11.11%)	⬆️
...rg/mozilla/fenix/settings/account/AccountUiView.kt	34.14% <0.00%> (-2.44%)	⬇️
...in/java/org/mozilla/fenix/perf/NavGraphProvider.kt	62.50% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a69a8f2...2c79736. Read the comment docs.

[rocketsroger]

Looks good to me. Some small nits. 👍

[rocketsroger]

nit: the expiry date might be too close?

[travis79]

It can be easily extended later if need-be. The data-review form for extending a collection is even shorter to help facilitate this.

[travis79]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?
   
   
   * This data will help us understand how users are interacting with credit cards and how they are using our autofill service.

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
   
   * We are building out our services to include credit cards storage and autofill, and we need to know how useful this is for the users and how we can best serve them when it comes to their shopping experiences. This data will help us establish a baseline to make product decisions as we build out these services.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?
   
   
   * There are no other alternatives.

4. Can current instrumentation answer these questions?
   
   
   * No.

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
Credit card manual save: A counter of the number of credit cards that have been saved manually by the user. Category 2 - interaction data #18711
Credit card delete: A counter of the number of credit cards that have been deleted by the user. Category 2 - interaction data #18711
Credit card autofill: A counter of the number of times the user has autofilled a credit card. Category 2 - interaction data #18711

1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
   
   * [https://dictionary.telemetry.mozilla.org/apps/fenix
     ](https://dictionary.telemetry.mozilla.org/apps/fenix%E2%80%A8)

2. How long will this data be collected? Choose one of the following:
   
   * I want this data to be collected for 6 months initially (ending on Oct 1, 2021), with the option to renew at that point.

3. What populations will you measure?
   
   * All channels, all locales, all countries

4. If this data collection is default on, what is the opt-out mechanism for users?
   
   
   * Default Glean SDK opt-out mechanism.

5. Please provide a general description of how you will analyze this data.
   
   
   * Glean and Amplitude.

6. Where do you intend to share the results of your analysis?
   
   * Only on Glean, Amplitude, and with mobile teams.

7. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
   
   
   * No third-party tools.

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   Yes, via the Glean Dictionary

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   Yes, by using the "Send Usage Data" toggle in the app settings

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   N/A, collection ending on 2021-10-1

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Category 2, Usage Data

5. Is the data collection request for default-on or default-off?
   Default-on

6. Does the instrumentation include the addition of any new identifiers?
   No

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes

8. Does the data collection use a third-party collection tool?
   No

Data Review Result

Approved: data-review+

[travis79]

Data-Review approval only, this doesn't cover any code review from me.

[eliserichards]

This is waiting on a Fact from AC: mozilla-mobile/android-components#10342

Addressed comment

[gabrielluong]

@eliserichards If there's nothing blocking this except for the AC bump, let's try to land some of probes and get a head start on the QA. We will probably want to do another review for the new facts.

[mergify]

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏