Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #18711 - Refactor credit card telemetry under the Metrics ping #19733

Merged
merged 1 commit into from May 31, 2021

Conversation

gabrielluong
Copy link
Member

Fixes #18711

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #19733 (6455281) into master (5c28e7d) will increase coverage by 0.04%.
The diff coverage is 77.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19733      +/-   ##
============================================
+ Coverage     35.35%   35.40%   +0.04%     
  Complexity     1649     1649              
============================================
  Files           545      545              
  Lines         22091    22097       +6     
  Branches       3280     3280              
============================================
+ Hits           7811     7824      +13     
+ Misses        13378    13370       -8     
- Partials        902      903       +1     
Impacted Files Coverage Δ
...java/org/mozilla/fenix/components/metrics/Event.kt 41.16% <ø> (-0.21%) ⬇️
...la/fenix/components/metrics/GleanMetricsService.kt 19.88% <ø> (+0.22%) ⬆️
...x/settings/creditcards/CreditCardEditorFragment.kt 0.00% <0.00%> (ø)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 26.00% <50.00%> (+0.48%) ⬆️
...zilla/fenix/components/metrics/MetricController.kt 36.00% <100.00%> (+1.77%) ⬆️
...editcards/controller/CreditCardEditorController.kt 41.17% <100.00%> (-3.27%) ⬇️
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 73.24% <100.00%> (+0.46%) ⬆️
...rg/mozilla/fenix/settings/account/AccountUiView.kt 36.58% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c1939...6455281. Read the comment docs.

@gabrielluong gabrielluong changed the title For #18711: Refactor credit card telemetry under the Metrics ping For #18711 - Refactor credit card telemetry under the Metrics ping May 31, 2021
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🚢

@gabrielluong gabrielluong added pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels May 31, 2021
@gabrielluong gabrielluong merged commit 172a118 into mozilla-mobile:master May 31, 2021
@gabrielluong gabrielluong deleted the 18711 branch May 31, 2021 21:40
grigoryk pushed a commit to grigoryk/fenix that referenced this pull request Jun 15, 2021
rocketsroger added a commit to rocketsroger/fenix that referenced this pull request Aug 5, 2021
mergify bot pushed a commit that referenced this pull request Aug 5, 2021
czlucius pushed a commit to czlucius/fenix that referenced this pull request Aug 20, 2021
czlucius pushed a commit to czlucius/fenix that referenced this pull request Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry] Credit Card Autofill
3 participants