This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #18711 - Refactor credit card telemetry under the Metrics ping #19733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielluong
force-pushed
the
18711
branch
2 times, most recently
from
May 31, 2021 20:31
dbea199
to
e39d54b
Compare
Codecov Report
@@ Coverage Diff @@
## master #19733 +/- ##
============================================
+ Coverage 35.35% 35.40% +0.04%
Complexity 1649 1649
============================================
Files 545 545
Lines 22091 22097 +6
Branches 3280 3280
============================================
+ Hits 7811 7824 +13
+ Misses 13378 13370 -8
- Partials 902 903 +1
Continue to review full report at Codecov.
|
gabrielluong
force-pushed
the
18711
branch
3 times, most recently
from
May 31, 2021 21:10
6b6c403
to
ea0e8bc
Compare
gabrielluong
changed the title
For #18711: Refactor credit card telemetry under the Metrics ping
For #18711 - Refactor credit card telemetry under the Metrics ping
May 31, 2021
rocketsroger
approved these changes
May 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 🚢
gabrielluong
added
pr:approved
PR that has been approved
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
labels
May 31, 2021
7 tasks
3 tasks
grigoryk
pushed a commit
to grigoryk/fenix
that referenced
this pull request
Jun 15, 2021
rocketsroger
added a commit
to rocketsroger/fenix
that referenced
this pull request
Aug 5, 2021
…er the Metrics ping (mozilla-mobile#19733)" This reverts commit 172a118.
czlucius
pushed a commit
to czlucius/fenix
that referenced
this pull request
Aug 20, 2021
…er the Metrics ping (mozilla-mobile#19733)" This reverts commit 172a118.
czlucius
pushed a commit
to czlucius/fenix
that referenced
this pull request
Aug 22, 2021
…er the Metrics ping (mozilla-mobile#19733)" This reverts commit 172a118.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
pr:approved
PR that has been approved
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18711
Pull Request checklist
To download an APK when reviewing a PR: