Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #20029: Remove animations when recreating activity on locale change. #20170

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Jun 25, 2021

This should also fix #20031.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #20170 (c3ad2fa) into master (9693507) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20170      +/-   ##
============================================
+ Coverage     36.51%   36.52%   +0.01%     
  Complexity     1625     1625              
============================================
  Files           541      541              
  Lines         21133    21135       +2     
  Branches       3169     3169              
============================================
+ Hits           7717     7720       +3     
  Misses        12540    12540              
+ Partials        876      875       -1     
Impacted Files Coverage Δ
...ttings/advanced/DefaultLocaleSettingsController.kt 76.19% <100.00%> (+2.50%) ⬆️
...rg/mozilla/fenix/settings/account/AccountUiView.kt 36.58% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9693507...c3ad2fa. Read the comment docs.

@mcarare mcarare added the needs:review PRs that need to be reviewed label Jun 25, 2021
@Mugurell
Copy link
Contributor

Mugurell commented Jul 5, 2021

I guess this is a speculative fix.
Can you provide more info about the scenario you're trying to fix and the proposed solution?

I think both issues (#20029 and #20031) are more so related to the async graph inflation and navigation @mcomella is working on.

@mcarare
Copy link
Contributor Author

mcarare commented Jul 5, 2021

This was a speculative fix, trying to remove any overhead that animations may add to activity recreation especially on fast consecutive ones. The fix was tested by QA both manually and on firebase and the crashes did not occur anymore.

@codrut-topliceanu codrut-topliceanu self-assigned this Jul 6, 2021
@codrut-topliceanu codrut-topliceanu self-requested a review July 6, 2021 13:54
Copy link
Contributor

@codrut-topliceanu codrut-topliceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mcarare mcarare added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Jul 7, 2021
@mergify mergify bot merged commit b43db5f into mozilla-mobile:master Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
4 participants