Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #20518: Renew performance telemetry probes #20519

Closed
wants to merge 2 commits into from
Closed

For #20518: Renew performance telemetry probes #20519

wants to merge 2 commits into from

Conversation

eliserichards
Copy link
Contributor

@eliserichards eliserichards commented Jul 26, 2021 •
edited

For #20518
Doc [waiting for approval from @mcomella]: https://docs.google.com/document/d/1NGlnTa9TPyTnd3ciUPbwujbITjkX8p8vJybXcZrrM2w/edit#

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jul 26, 2021
@eliserichards eliserichards requested review from a team as code owners July 26, 2021 17:30
@mcomella mcomella mentioned this pull request Jul 28, 2021
Closed
mcomella added a commit to mcomella/fenix that referenced this pull request Jul 30, 2021
@mcomella
For mozilla-mobile#20519: renew perf telemetry probes (August expiry).
d670e30 
I used eliserichards' PR mozilla-mobile#20519 to
renew more easily.
@pocmo
Copy link
Contributor

pocmo commented Aug 2, 2021

Merged main into this branch, but it looks there are still probe related tests failing (which are failing everywhere right now):

  • FenixApplicationTest. WHEN setStartupMetrics is called THEN sets some base metrics
  • GleanMetricsServiceTest. TabsTray events are correctly recorded

(And one unrelated, intermittent mockk error that I will look at separately)

  • DefaultBrowserToolbarControllerTest. handleToolbarCloseTabPress

https://firefoxci.taskcluster-artifacts.net/HTdjWmE-TKSl3UCQX98bBg/0/public/reports/test/testDebugUnitTest/index.html

@pocmo pocmo mentioned this pull request Aug 2, 2021
Merged
@mcomella mcomella mentioned this pull request Aug 2, 2021
Merged
3 tasks
@mcomella
Copy link
Contributor

mcomella commented Aug 2, 2021

Closing in favor of #20623

@mcomella mcomella closed this Aug 2, 2021
mcomella added a commit to mcomella/fenix that referenced this pull request Aug 2, 2021
@mcomella
For mozilla-mobile#20519: link to data renewal request.
b0115e6
mcomella added a commit to mcomella/fenix that referenced this pull request Aug 2, 2021
@mcomella
For mozilla-mobile#20519: disable metrics we don't want to renew.
763df04
mcomella added a commit to mcomella/fenix that referenced this pull request Aug 2, 2021
@mcomella
For mozilla-mobile#20518: renew perf telemetry probes (August expiry).
be22b94 
I used eliserichards' PR mozilla-mobile#20519 to
renew more easily.
mcomella added a commit to mcomella/fenix that referenced this pull request Aug 2, 2021
@mcomella
For mozilla-mobile#20518: renew perf telemetry probes (August expiry).
789d2ad 
I used eliserichards' PR mozilla-mobile#20519 to
renew more easily.
eliserichards pushed a commit to mcomella/fenix that referenced this pull request Aug 2, 2021
@mcomella
For mozilla-mobile#20518: renew perf telemetry probes (August expiry).
ea40d08 
I used eliserichards' PR mozilla-mobile#20519 to
renew more easily.
mergify bot pushed a commit that referenced this pull request Aug 2, 2021
@mcomella @mergify
For #20518: renew perf telemetry probes (August expiry).
bbd80b9 
I used eliserichards' PR #20519 to
renew more easily.
czlucius pushed a commit to czlucius/fenix that referenced this pull request Aug 20, 2021
@mcomella @czlucius
For mozilla-mobile#20518: renew perf telemetry probes (August expiry).
7949ac8 
I used eliserichards' PR mozilla-mobile#20519 to
renew more easily.
czlucius pushed a commit to czlucius/fenix that referenced this pull request Aug 22, 2021
@mcomella @czlucius
For mozilla-mobile#20518: renew perf telemetry probes (August expiry).
5cc7c3f 
I used eliserichards' PR mozilla-mobile#20519 to
renew more easily.
mergify bot pushed a commit that referenced this pull request Aug 25, 2021
@mcomella
For #20518: renew perf telemetry probes (August expiry).
61b0c5d 
I used eliserichards' PR #20519 to
renew more easily.

(cherry picked from commit bbd80b9)
eliserichards pushed a commit that referenced this pull request Aug 25, 2021
@mergify @mcomella
For #20519: renew perf telemetry probes (August expiry). (backport #2…
5438d16 
…0623) (#21020)

* For #20518: renew perf telemetry probes (August expiry).

I used eliserichards' PR #20519 to
renew more easily.

(cherry picked from commit bbd80b9)

* For #20518: link to data renewal request.

(cherry picked from commit 296dc9c)

* For #20518: disable metrics we don't want to renew.

(cherry picked from commit 700033e)

* For #20518: disable metrics we don't want to renew.

Co-authored-by: Michael Comella <michael.l.comella@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mcomella mcomella

Labels
🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eliserichards @pocmo @mcomella